From: Nadim Almas <nadim.902@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Lidza Louina <lidza.louina@gmail.com>,
markh@compro.net, devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue
Date: Thu, 6 Oct 2016 20:53:01 +0530 [thread overview]
Message-ID: <CANQNnfE2ha36bNd6yC+0CT=T5y86j3b_RhWu6ih4=c75o3qQwQ@mail.gmail.com> (raw)
In-Reply-To: <CANQNnfEB+KHRXkc6HpSqt6FcX6560juCybqSpuX6XpgsjxAaRg@mail.gmail.com>
May be it is not looking better than it did before but it removed 6 warning of
the file which is shown by running "perl scripts/checkpatch.pl -f
drivers/staging/dgnc/* | less" commend
than why it is not acceptable
On Thu, Oct 6, 2016 at 1:52 PM, Nadim Almas <nadim.902@gmail.com> wrote:
> May be it is not looking better than yours but it removed 6 warning of
> the file which is shown by running "perl scripts/checkpatch.pl -f
> drivers/staging/dgnc/* | less" commend
>
> On Thu, Oct 6, 2016 at 10:51 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> On Wed, Oct 05, 2016 at 02:53:58PM -0700, Nadim Almas wrote:
>>> Fixed coding style issue
>>>
>>> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
>>> ---
>>> drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
>>> 1 file changed, 12 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
>>> index abddd48..65994e3 100644
>>> --- a/drivers/staging/dgnc/dgnc_neo.h
>>> +++ b/drivers/staging/dgnc/dgnc_neo.h
>>> @@ -30,7 +30,8 @@
>>> struct neo_uart_struct {
>>> u8 txrx; /* WR RHR/THR - Holding Reg */
>>> u8 ier; /* WR IER - Interrupt Enable Reg */
>>> - u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
>>> + u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo Control */
>>> + /*Reg */
>>
>> Does that really look better now than it did before?
>>
>> I don't think so :(
>>
>> sorry,
>>
>> greg k-h
next prev parent reply other threads:[~2016-10-06 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 21:53 [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue Nadim Almas
2016-10-06 5:21 ` Greg KH
2016-10-06 8:22 ` Nadim Almas
2016-10-06 15:23 ` Nadim Almas [this message]
2016-10-06 15:52 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2016-09-30 21:49 Nadim Almas
2016-10-02 15:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANQNnfE2ha36bNd6yC+0CT=T5y86j3b_RhWu6ih4=c75o3qQwQ@mail.gmail.com' \
--to=nadim.902@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).