From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939006AbcJSOPH (ORCPT ); Wed, 19 Oct 2016 10:15:07 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:36772 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938937AbcJSOPC (ORCPT ); Wed, 19 Oct 2016 10:15:02 -0400 MIME-Version: 1.0 In-Reply-To: References: <1476409733-5133-1-git-send-email-wanpeng.li@hotmail.com> <20161016133911.GI3142@twins.programming.kicks-ass.net> <20161017082250.GX3568@worktop.programming.kicks-ass.net> <938757058.3991379.1476698922290.JavaMail.zimbra@redhat.com> From: Wanpeng Li Date: Wed, 19 Oct 2016 22:01:57 +0800 Message-ID: Subject: Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() To: Paolo Bonzini Cc: Peter Zijlstra , "linux-kernel@vger.kernel.org" , Wanpeng Li , Ingo Molnar , Mike Galbraith , Thomas Gleixner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-10-18 8:01 GMT+08:00 Wanpeng Li : > 2016-10-17 18:08 GMT+08:00 Paolo Bonzini : > [...] >>> > Something like the below avoids all that. Paravirt will still need fixing. >>> >>> kvm_guest_apic_eoi_write >>> -> native_apic_msr_write >> >> kvm_guest_apic_eoi_write can use native_apic_msr_eoi_write too: >> >> diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h >> index f5aaf6c83222..9769d76a62c4 100644 >> --- a/arch/x86/include/asm/apic.h >> +++ b/arch/x86/include/asm/apic.h >> @@ -174,7 +174,7 @@ static inline void disable_local_APIC(void) { } >> static inline void lapic_update_tsc_freq(void) { } >> #endif /* !CONFIG_X86_LOCAL_APIC */ >> >> -#ifdef CONFIG_X86_X2APIC >> +#if defined CONFIG_X86_X2APIC || defined CONFIG_KVM_GUEST > > If CONFIG_X86_X2APIC is undefined and CONFIG_KVM_GUEST is defined, > there are undefined reference warning for x2apic_mode and check_x2apic > etc since they are extern variables and just define under > CONFIG_X86_X2APIC. [...] > > If -cpu host,-x2apic we should go through mmio when writes xapic EOI. Any ideas? :) Regards, Wanpeng Li