From: Wanpeng Li <kernellwp@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
Radim Krcmar <rkrcmar@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH 2/2] KVM: X86: Implement PV send IPI support
Date: Sat, 30 Jun 2018 18:04:47 +0800 [thread overview]
Message-ID: <CANRm+CwjHX7Dr61aFHoSEftrj-nPMpyj9DGktg8wzXJ-zzNuFA@mail.gmail.com> (raw)
In-Reply-To: <96bad133-077d-e27d-9f57-4df6399eb3b8@redhat.com>
On Fri, 29 Jun 2018 at 18:45, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 29/06/2018 11:51, Wanpeng Li wrote:
> > From: Wanpeng Li <wanpengli@tencent.com>
> >
> > Using hypercall to send IPIs by one vmexit instead of one by one for
> > xAPIC/x2APIC physical mode and one vmexit per-cluster for x2APIC cluster
> > mode.
> >
> > Even if enable qemu interrupt remapping and PV TLB Shootdown, I can still
> > observe ~14% performance boost by ebizzy benchmark for 64 vCPUs VM, the
> > total msr-induced vmexits reduce ~70%.
> >
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Radim Krčmář <rkrcmar@redhat.com>
> > Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> > Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> > ---
> > Documentation/virtual/kvm/cpuid.txt | 4 ++++
> > arch/x86/kvm/cpuid.c | 3 ++-
> > arch/x86/kvm/x86.c | 25 +++++++++++++++++++++++++
> > include/uapi/linux/kvm_para.h | 1 +
> > 4 files changed, 32 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/virtual/kvm/cpuid.txt b/Documentation/virtual/kvm/cpuid.txt
> > index ab022dc..d72359f 100644
> > --- a/Documentation/virtual/kvm/cpuid.txt
> > +++ b/Documentation/virtual/kvm/cpuid.txt
> > @@ -62,6 +62,10 @@ KVM_FEATURE_ASYNC_PF_VMEXIT || 10 || paravirtualized async PF VM exit
> > || || can be enabled by setting bit 2
> > || || when writing to msr 0x4b564d02
> > ------------------------------------------------------------------------------
> > +KVM_FEATURE_PV_SEND_IPI || 11 || guest checks this feature bit
> > + || || before enabling paravirtualized
> > + || || send IPIs.
>
> It's not "enabling" but "using". You also need to document the
> hypercall itself.
Will fix it in v2.
Regards,
Wanpeng Li
prev parent reply other threads:[~2018-06-30 10:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 9:51 [PATCH 0/2] KVM: x86: Add PV IPIs support Wanpeng Li
2018-06-29 9:51 ` [PATCH 1/2] KVM: X86: Implement PV IPI in linux guest Wanpeng Li
2018-06-29 10:10 ` Vitaly Kuznetsov
2018-06-30 10:04 ` Wanpeng Li
2018-06-29 11:22 ` kbuild test robot
2018-06-29 13:01 ` kbuild test robot
2018-06-29 9:51 ` [PATCH 2/2] KVM: X86: Implement PV send IPI support Wanpeng Li
2018-06-29 10:09 ` Vitaly Kuznetsov
2018-06-29 10:48 ` Paolo Bonzini
2018-06-30 10:05 ` Wanpeng Li
2018-06-29 10:45 ` Paolo Bonzini
2018-06-30 10:04 ` Wanpeng Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANRm+CwjHX7Dr61aFHoSEftrj-nPMpyj9DGktg8wzXJ-zzNuFA@mail.gmail.com \
--to=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).