From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752851AbcGSGxW (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jul 2016 02:53:22 -0400
Received: from mail-oi0-f65.google.com ([209.85.218.65]:34925 "EHLO
	mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752265AbcGSGxT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jul 2016 02:53:19 -0400
MIME-Version: 1.0
In-Reply-To: <1468633869-4066-1-git-send-email-wanpeng.li@hotmail.com>
References: <1468633869-4066-1-git-send-email-wanpeng.li@hotmail.com>
From: Wanpeng Li <kernellwp@gmail.com>
Date: Tue, 19 Jul 2016 14:53:18 +0800
Message-ID: <CANRm+CyK_OhQkM-KwDyBH=e7D-Koa8tsOi_AJbprF_QAYJE7Pw@mail.gmail.com>
Subject: Re: [PATCH v4] locking/pvqspinlock: Fix double hash race
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>
Cc: Wanpeng Li <wanpeng.li@hotmail.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>, Waiman Long <Waiman.Long@hpe.com>,
        Davidlohr Bueso <dave@stgolabs.net>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sorry for the quick ping, but could we catch the merge window? Ingo. :)
2016-07-16 9:51 GMT+08:00 Wanpeng Li <kernellwp@gmail.com>:
> From: Wanpeng Li <wanpeng.li@hotmail.com>
>
> When the lock holder vCPU is racing with the queue head vCPU:
>
> lock holder vCPU             queue head vCPU
> =====================        ==================
>
> node->locked = 1;
> <preemption>                 READ_ONCE(node->locked)
>    ...                       pv_wait_head_or_lock():
>                                SPIN_THRESHOLD loop;
>                                pv_hash();
>                                lock->locked = _Q_SLOW_VAL;
>                                node->state  = vcpu_hashed;
> pv_kick_node():
>   cmpxchg(node->state,
>      vcpu_halted, vcpu_hashed);
>   lock->locked = _Q_SLOW_VAL;
>   pv_hash();
>
> With preemption at the right moment, it is possible that both the
> lock holder and queue head vCPUs can be racing to set node->state
> which can result in hash entry race. Making sure the state is never
> set to vcpu_halted will prevent this racing from happening.
>
> This patch fix it by setting vcpu_hashed after we did all hash thing.
>
> Reviewed-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
> Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Waiman Long <Waiman.Long@hpe.com>
> Cc: Davidlohr Bueso <dave@stgolabs.net>
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> ---
> v3 -> v4:
>  * update patch subject
>  * add code comments
> v2 -> v3:
>  * fix typo in patch description
> v1 -> v2:
>  * adjust patch description
>
>  kernel/locking/qspinlock_paravirt.h | 23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/locking/qspinlock_paravirt.h b/kernel/locking/qspinlock_paravirt.h
> index 21ede57..ca96db4 100644
> --- a/kernel/locking/qspinlock_paravirt.h
> +++ b/kernel/locking/qspinlock_paravirt.h
> @@ -450,7 +450,28 @@ pv_wait_head_or_lock(struct qspinlock *lock, struct mcs_spinlock *node)
>                                 goto gotlock;
>                         }
>                 }
> -               WRITE_ONCE(pn->state, vcpu_halted);
> +               /*
> +                * lock holder vCPU             queue head vCPU
> +                * ----------------             ---------------
> +                * node->locked = 1;
> +                * <preemption>                 READ_ONCE(node->locked)
> +                *    ...                       pv_wait_head_or_lock():
> +                *                                SPIN_THRESHOLD loop;
> +                *                                pv_hash();
> +                *                                lock->locked = _Q_SLOW_VAL;
> +                *                                node->state  = vcpu_hashed;
> +                * pv_kick_node():
> +                *   cmpxchg(node->state,
> +                *      vcpu_halted, vcpu_hashed);
> +                *   lock->locked = _Q_SLOW_VAL;
> +                *   pv_hash();
> +                *
> +                * With preemption at the right moment, it is possible that both the
> +                * lock holder and queue head vCPUs can be racing to set node->state.
> +                * Making sure the state is never set to vcpu_halted will prevent this
> +                * racing from happening.
> +                */
> +               WRITE_ONCE(pn->state, vcpu_hashed);
>                 qstat_inc(qstat_pv_wait_head, true);
>                 qstat_inc(qstat_pv_wait_again, waitcnt);
>                 pv_wait(&l->locked, _Q_SLOW_VAL);
> --
> 2.1.0
>



-- 
Regards,
Wanpeng Li