From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751643AbdCANjn (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Mar 2017 08:39:43 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:33627 "EHLO
        mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751334AbdCANjj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Mar 2017 08:39:39 -0500
MIME-Version: 1.0
In-Reply-To: <CANRm+CwTqU-1b_mSoc5nNtYS53WqDamcxgpTTvaJDDnyb=T-Xg@mail.gmail.com>
References: <20170119101924.GJ6485@twins.programming.kicks-ass.net>
 <20170119133633.GB6536@twins.programming.kicks-ass.net> <CANRm+CwH7mUkHGshKLJH5R28LUVHxfHiqfYP+CQYyhMUrnWo0g@mail.gmail.com>
 <20170227124349.GU6515@twins.programming.kicks-ass.net> <3e7c34e2-757b-19e9-f7e5-9bfaadd79e5d@redhat.com>
 <20170227130440.GW6500@twins.programming.kicks-ass.net> <15367170-e1c0-8901-7e15-940d8d699c21@redhat.com>
 <20170227155954.GY6500@twins.programming.kicks-ass.net> <111f89b9-22e3-5a0f-3469-6f64092521ff@redhat.com>
 <CANRm+CyP8-7JoZSta87aZdRRqU862n57AAFAWm7v8Xs3twBUSg@mail.gmail.com>
 <20170228080855.GV6515@twins.programming.kicks-ass.net> <CANRm+CwTqU-1b_mSoc5nNtYS53WqDamcxgpTTvaJDDnyb=T-Xg@mail.gmail.com>
From: Wanpeng Li <kernellwp@gmail.com>
Date: Wed, 1 Mar 2017 21:39:18 +0800
Message-ID: <CANRm+Cy_BOeWkTX+GRrB_kdAY4p2KT7_2G+7tbrEi9pQbt7vXQ@mail.gmail.com>
Subject: Re: tip.today - scheduler bam boom crash (cpu hotplug)
To: Peter Zijlstra <peterz@infradead.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Mike Galbraith <efault@gmx.de>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
        Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2017-02-28 16:11 GMT+08:00 Wanpeng Li <kernellwp@gmail.com>:
> 2017-02-28 16:08 GMT+08:00 Peter Zijlstra <peterz@infradead.org>:
>> On Tue, Feb 28, 2017 at 09:51:07AM +0800, Wanpeng Li wrote:
>>> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
>>> index 4e95b2e..ed8eda4 100644
>>> --- a/arch/x86/kernel/cpu/amd.c
>>> +++ b/arch/x86/kernel/cpu/amd.c
>>> @@ -557,7 +557,7 @@ static void early_init_amd(struct cpuinfo_x86 *c)
>>>          set_cpu_cap(c, X86_FEATURE_NONSTOP_TSC);
>>>          if (check_tsc_unstable())
>>>              clear_sched_clock_stable();
>>> -    } else {
>>> +    } else if (!boot_cpu_has(X86_FEATURE_HYPERVISOR)) {
>>>          clear_sched_clock_stable();
>>>      }
>>
>> That's wrong, you can have HYPERVISOR and still use
>> native_sched_clock() (lguest does that for one).
>
> My posting delay to check this in tsc_init().

Does it make sense?

Regards,
Wanpeng Li