From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753546AbdKILIz (ORCPT ); Thu, 9 Nov 2017 06:08:55 -0500 Received: from mail-ot0-f194.google.com ([74.125.82.194]:56826 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752930AbdKILIx (ORCPT ); Thu, 9 Nov 2017 06:08:53 -0500 X-Google-Smtp-Source: AGs4zMYGZZCRah8HC0aUnZBUKmPOw3LMH6Cq7i7KH05vw19LqCgsYqxlKbnIOpSmVu91N66PIhJDBJIXpBIoUgDBRrc= MIME-Version: 1.0 In-Reply-To: <93c53d82-2b62-bb74-c472-8923bb2893aa@redhat.com> References: <1510192934-5369-1-git-send-email-wanpeng.li@hotmail.com> <1510192934-5369-3-git-send-email-wanpeng.li@hotmail.com> <93c53d82-2b62-bb74-c472-8923bb2893aa@redhat.com> From: Wanpeng Li Date: Thu, 9 Nov 2017 19:08:52 +0800 Message-ID: Subject: Re: [PATCH RESEND 2/3] KVM: Add paravirt remote TLB flush To: Paolo Bonzini Cc: "linux-kernel@vger.kernel.org" , kvm , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Wanpeng Li , Eduardo Valentin Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-11-09 19:02 GMT+08:00 Paolo Bonzini : > On 09/11/2017 12:01, Wanpeng Li wrote: >> 2017-11-09 18:48 GMT+08:00 Paolo Bonzini : >>> On 09/11/2017 03:02, Wanpeng Li wrote: >>>> @@ -484,6 +511,8 @@ void __init kvm_guest_init(void) >>>> pv_time_ops.steal_clock = kvm_steal_clock; >>>> } >>>> >>>> + pv_mmu_ops.flush_tlb_others = kvm_flush_tlb_others; >>> >>> This needs to be keyed on a new CPUID feature bit. Eduardo is also >> >> Will do. >> >>> adding a new "PV_DEDICATED" hint and you might disable PV TLB flush when >>> PV_DEDICATED is set. >> >> Why disable PV TLB flush for PV_DEDICATED(qspinlock)? > > PV_DEDICATED says pretty much that it is very unlikely to have a > preempted vCPU. Therefore, the cpumask loop is unnecessary. Thanks for pointing out this. :) Regards, Wanpeng Li