From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DEE0C43461 for ; Mon, 14 Sep 2020 06:57:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32A2A207EA for ; Mon, 14 Sep 2020 06:57:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c2eeTVMq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726135AbgING5K (ORCPT ); Mon, 14 Sep 2020 02:57:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726118AbgING5J (ORCPT ); Mon, 14 Sep 2020 02:57:09 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C2F4C06174A; Sun, 13 Sep 2020 23:57:08 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id h17so13974146otr.1; Sun, 13 Sep 2020 23:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M3lztHJyBuAkCA+eiG2skA0kVPp/UdnzOX3/EVQJ58M=; b=c2eeTVMqM6vwsjE4/Y+k756O2OHzXBtbHmd5vYI//w4CLJZNFUkz8lVfV3xQ1bEE34 FJ8JWGiROaUIKI+/h72MGlLjda1nINgvtpkmgxUVWulRHvP33VRQBljFsYIqdwfBGc9A HlY7j+sOYdFlRFRuG4i92kBMsy4oyGVcKcmH9diiROwBqM/bj2DQQMuYKUw6ZWWXr3VG KTxJRA/ODSsBp9+A4gKUSef78+TDlHUMJ37RpbVcruRZ8mbprz9hptoWzLKQrBl4nflC CU05PnEfIEGwyNTKnQ2YdDXB2rxlVkyqQAwmjEcVWU3kybFoTOAftDnc9ClE6dbyeCiw syvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M3lztHJyBuAkCA+eiG2skA0kVPp/UdnzOX3/EVQJ58M=; b=R6kWJioILCQc1glGU+tEGYfbEYmGgQWgqLa05GvrejxHdT2llrjwY3/mf3PzvWh2Bb 16D7DFOpPm+AyAOwDiXvWvZtr5Fo07z5TK21i5FHff6J2sYc4z6Xq6FeQABSroJt9FNB cBnN1BIAZHio+9fQVfF5l0Jy8X0bUzk9Hma11Qd7IV92FIES7hx1G39ZTg6+KwH3yKwO EjFwx2L0/0Zv8OZoiBjfuMrfy0IWarzObiQUlHzX6dxJNC4K5KFcTCuk9V3WA928lO13 4tp7yepCvEvF8q8tu/VSsnvZ4ijeJL3OobsIbAmrbjcy6BlT4nIYi5Fz0A6gx1dnkOi5 8P7Q== X-Gm-Message-State: AOAM5338aLI5Aeanj/P5vqdny1FwKgo0KGXbJKJlFCfL/OWXcTieylaY VNfCJrbQMgpQLJ6/HzzfL8yhuyZsTidX1zhDSq4= X-Google-Smtp-Source: ABdhPJx7izQYe3ulaf66DbqL4RgbNwxFT0b8i8vijkzANZ//Spy5qiJy/X8DQUwQ+hrM7VGTmFoa3Um0hDB6WUq3glY= X-Received: by 2002:a05:6830:10c4:: with SMTP id z4mr7613377oto.254.1600066623740; Sun, 13 Sep 2020 23:57:03 -0700 (PDT) MIME-Version: 1.0 References: <1599620119-12971-1-git-send-email-wanpengli@tencent.com> <87eenbmjo4.fsf@vitty.brq.redhat.com> In-Reply-To: From: Wanpeng Li Date: Mon, 14 Sep 2020 14:56:52 +0800 Message-ID: Subject: Re: [PATCH 2/3] KVM: SVM: Move svm_complete_interrupts() into svm_vcpu_run() To: Paolo Bonzini Cc: Vitaly Kuznetsov , LKML , kvm , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel , "Paul K ." Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 12 Sep 2020 at 14:20, Paolo Bonzini wrote: > > On 09/09/20 10:47, Wanpeng Li wrote: > >> One more thing: > >> > >> VMX version does > >> > >> vmx_complete_interrupts(vmx); > >> if (is_guest_mode(vcpu)) > >> return EXIT_FASTPATH_NONE; > >> > >> and on SVM we analyze is_guest_mode() inside > >> svm_exit_handlers_fastpath() - should we also change that for > >> conformity? > > > > Agreed, will do in v2. > > Please just send an incremental patch. Thanks! Just sent out a patch to do it. :) Wanpeng