From: Wanpeng Li <kernellwp@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>, "Radim Krčmář" <rkrcmar@redhat.com>,
"Wanpeng Li" <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay
Date: Thu, 29 Jun 2017 16:17:55 +0800 [thread overview]
Message-ID: <CANRm+CzmeoA_zvtr+8QymzGyey4xsr3hBc+S8QBxA5Ad2dQ3=A@mail.gmail.com> (raw)
In-Reply-To: <62c6b468-52c0-38c5-e15f-c770483188cd@redhat.com>
2017-06-29 15:55 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>> +
>> + /* In case the sw timer triggered in the window */
>> + if (atomic_read(&apic->lapic_timer.pending) &&
>> + !apic_lvtt_period(apic))
>> + need_cancel = true;
>> + else if (r && (apic_lvtt_oneshot(apic) ||
>> apic_lvtt_tscdeadline(apic)))
>> + apic_timer_expired(apic);
>> + }
>> + }
[...]
>
> You still need to enable the preemption timer even if you return 1, so
> in lapic.c it becomes
>
> if (!apic_lvtt_period(apic)) {
> if (r)
> apic_timer_expired(apic);
> if (atomic_read(&apic->lapic_timer.pending))
> need_cancel = true;
> }
I think the codes are more clear but the same as above. We didn't
program preemption timer vmcs field if delta == 0, so how to
understand "need to enable the preemption timer even if return 1"?
>
>
> Otherwise it looks good. Thanks for your persistence. :)
Thanks for your help and patient. :)
Regards,
Wanpeng Li
next prev parent reply other threads:[~2017-06-29 8:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 1:29 [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li
2017-06-28 12:10 ` Paolo Bonzini
2017-06-28 13:55 ` Wanpeng Li
2017-06-28 14:00 ` Paolo Bonzini
2017-06-28 14:05 ` Wanpeng Li
2017-06-28 14:27 ` Wanpeng Li
2017-06-28 14:30 ` Paolo Bonzini
2017-06-29 3:42 ` Wanpeng Li
2017-06-29 7:55 ` Paolo Bonzini
2017-06-29 8:17 ` Wanpeng Li [this message]
2017-06-29 8:44 ` Wanpeng Li
2017-06-29 11:43 ` Paolo Bonzini
2017-06-29 11:54 ` Wanpeng Li
2017-06-29 12:05 ` Wanpeng Li
2017-06-29 12:13 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANRm+CzmeoA_zvtr+8QymzGyey4xsr3hBc+S8QBxA5Ad2dQ3=A@mail.gmail.com' \
--to=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).