From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754555AbdKIWc1 (ORCPT ); Thu, 9 Nov 2017 17:32:27 -0500 Received: from mail-ua0-f179.google.com ([209.85.217.179]:48997 "EHLO mail-ua0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225AbdKIWcZ (ORCPT ); Thu, 9 Nov 2017 17:32:25 -0500 X-Google-Smtp-Source: ABhQp+TZz/Hb6O1q/DpsBq8w/roFKBIwfnmnU915OkehzCME+4hxQ1wKtPWMsFHRD/x/C7wd5aq+Z6VkRLQxNHb6PE0= MIME-Version: 1.0 In-Reply-To: References: <20171103172947.15156-1-benjamin.tissoires@redhat.com> <20171106080503.GB9728@mail.corp.redhat.com> From: Jason Gerecke Date: Thu, 9 Nov 2017 14:32:23 -0800 Message-ID: Subject: Re: [PATCH] HID: Wacom: switch Dell canvas into highres mode To: Jiri Kosina Cc: Benjamin Tissoires , Ping Cheng , Linux Input , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vA9MWWkK020311 On Thu, Nov 9, 2017 at 3:42 AM, Jiri Kosina wrote: > On Mon, 6 Nov 2017, Benjamin Tissoires wrote: > >> > >well, this is not the cleanest way of handling this mode set, but it >> > >is the less intrusive AFAICT. >> > > >> > >I was thinking that we might want to add a new field in struct >> > >wacom_feature, but then it wouldn't make sense to keep the set mode >> > >specifics in _wacom_query_tablet_data(). >> > > >> > >So I am open to any better suggestion, but this one works and the >> > >impact on other HID generic tablets is null. >> > > >> > >> > Hmm. Agreed that this isn't ideal. I'd like to take a look at the >> > descriptor, if you wouldn't mind sharing it. The hardware should be >> > similar to other devices of ours and it might be possible to piggyback >> > on existing code. >> > >> >> Sure, here it comes in the hid-replay format (and with a recording >> of a single dot from the pen): > > Jason, > > any word on the descriptor please, did you have time to analyze it? > > Merge window for 4.15 is almost there, so in case you don't want to miss > it, I'd need your Ack/Nack/Postopne rather quickly. > > Thanks, > > -- > Jiri Kosina > SUSE Labs > I spent some time checking for similar devices and didn't anything with a descriptor quite like it. That said, there's a good chance that we'll see something similar in the future... I'm still not entirely happy with the one-off approach, but I'll but my stamp of approval on it. We can work out a more generic way to detect and configure these dual-resolution devices going forward :) Reviewed-by: Jason Gerecke Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three, / So you look at the sixty-fours....