From: Dustin Kirkland <dustin.kirkland@gazzang.com>
To: Tyler Hicks <tyhicks@canonical.com>
Cc: Li Wang <liwang@nudt.edu.cn>,
ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH] eCryptfs: infinite loop bug
Date: Thu, 19 Jan 2012 08:03:57 -0600 [thread overview]
Message-ID: <CANT6BaOqXwut5iA2ADO_2avW2kCSV0WL_6=3Vv1zdFNXrnXjPA@mail.gmail.com> (raw)
In-Reply-To: <20120119084836.GA29477@boyd>
On Thu, Jan 19, 2012 at 2:48 AM, Tyler Hicks <tyhicks@canonical.com> wrote:
> On 2012-01-19 09:44:36, Li Wang wrote:
>>
>>
>> Hi,
>> Thanks Cong Wang for the kind reminding regarding the patch format.
>
> The commit message still needs some work. But there's no need to drag
> out the process for a fix like this, so I'll rewrite the commit message
> and reply to this email with the cleaned up version. Let me know if you
> have any problems with that. You'll still be credited as the author.
>
> For future kernel patches, please see "15) The canonical patch format"
> of Documentation/SubmittingPatches and "5.4: PATCH FORMATTING AND
> CHANGELOGS" of Documentation/development-process/5.Posting for more
> information on how the commit message should be written.
>
> Also, your email came across in base64 encoding. I'm not sure of the
> reason for that or how to fix it.
>
>> We did notice that the total_remaining_zeroes need be revised as well,
>> and the start_offset_in_page, num_bytes need not be revised (always smaller
>
> Yes, size_t will work fine, as Linus confirmed.
>
>> than PAGE_CACHE_SIZE, even the huge page size is supported,
>> the 4G page size is not present in the current world?)
>> but we forget to include the revision for total_remaining_zeroes, so here comes the patch.
>
> I really appreciate the patch - thanks!
Tyler,
Is this the problem behind our long standing
tor-download-on-ecryptfs-hangs-cpu bug?
* https://bugs.launchpad.net/ecryptfs/+bug/431975
--
:-Dustin
Dustin Kirkland
Chief Architect
Gazzang, Inc.
www.gazzang.com
next prev parent reply other threads:[~2012-01-19 14:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 7:30 [PATCH] eCryptfs: infinite loop bug Li Wang
2012-01-18 15:26 ` Cong Wang
2012-01-18 21:40 ` Tyler Hicks
2012-01-19 3:43 ` Linus Torvalds
[not found] ` <526922120.05125@eyou.net>
2012-01-19 1:44 ` Li Wang
2012-01-19 8:48 ` Tyler Hicks
2012-01-19 14:03 ` Dustin Kirkland [this message]
2012-01-19 15:08 ` Tyler Hicks
2012-01-19 9:13 ` [PATCH] eCryptfs: infinite loop due to overflow in ecryptfs_write() Tyler Hicks
2012-01-19 15:09 ` Cong Wang
[not found] <7f1e961d.f528.134efaf8348.Coremail.dragonylffly@163.com>
2012-01-18 20:49 ` [PATCH] eCryptfs: infinite loop bug Linus Torvalds
2012-01-18 21:04 ` Tyler Hicks
2012-01-19 16:17 ` Dustin Kirkland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANT6BaOqXwut5iA2ADO_2avW2kCSV0WL_6=3Vv1zdFNXrnXjPA@mail.gmail.com' \
--to=dustin.kirkland@gazzang.com \
--cc=ecryptfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwang@nudt.edu.cn \
--cc=tyhicks@canonical.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).