linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Chant <achant@google.com>
To: Benson Leung <bleung@chromium.org>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, Benson Leung <bleung@google.com>
Subject: Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.
Date: Fri, 23 Mar 2018 18:08:07 -0700	[thread overview]
Message-ID: <CANVWZtGS9x-zLAgtV0rkgnBR0kLHTT0LYjKEreNy6qjkcC75PA@mail.gmail.com> (raw)
In-Reply-To: <CANVWZtHTuU-_zjvj8gjXXA-2VUU2zxsu=afcqZC8Oen_bFmk6A@mail.gmail.com>

On Fri, Mar 23, 2018 at 5:48 PM, Andrew Chant <achant@google.com> wrote:
> On Fri, Mar 23, 2018 at 5:33 PM, Benson Leung <bleung@chromium.org> wrote:
>> Print bcdDevice which is used by vendors to identify different versions
>> of the same product (or different versions of firmware).
>>
>> Adding this to the logs will be useful for support purposes.
>>
>> Signed-off-by: Benson Leung <bleung@chromium.org>
>> ---
>>  drivers/usb/core/hub.c | 16 +++++++++-------
>>  1 file changed, 9 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
>> index aaeef03c0d83..739d599814b6 100644
>> --- a/drivers/usb/core/hub.c
>> +++ b/drivers/usb/core/hub.c
>> @@ -2192,14 +2192,16 @@ static void show_string(struct usb_device *udev, char *id, char *string)
>>
>>  static void announce_device(struct usb_device *udev)
>>  {
>> -       dev_info(&udev->dev, "New USB device found, idVendor=%04x, idProduct=%04x\n",
>> -               le16_to_cpu(udev->descriptor.idVendor),
>> -               le16_to_cpu(udev->descriptor.idProduct));
>>         dev_info(&udev->dev,
>> -               "New USB device strings: Mfr=%d, Product=%d, SerialNumber=%d\n",
>> -               udev->descriptor.iManufacturer,
>> -               udev->descriptor.iProduct,
>> -               udev->descriptor.iSerialNumber);
>> +                "New USB device found, idVendor=%04x, idProduct=%04x, bcdDevice=%04x\n",
>> +                le16_to_cpu(udev->descriptor.idVendor),
>> +                le16_to_cpu(udev->descriptor.idProduct),
>> +                le16_to_cpu(udev->descriptor.bcdDevice));
>> +       dev_info(&udev->dev,
>> +                "New USB device strings: Mfr=%d, Product=%d, SerialNumber=%d\n",
>> +                udev->descriptor.iManufacturer,
>> +                udev->descriptor.iProduct,
>> +                udev->descriptor.iSerialNumber);
>>         show_string(udev, "Product", udev->product);
>>         show_string(udev, "Manufacturer", udev->manufacturer);
>>         show_string(udev, "SerialNumber", udev->serial);
>> --
>> 2.17.0.rc0.231.g781580f067-goog
>>
>
>> +                "New USB device found, idVendor=%04x, idProduct=%04x, bcdDevice=%04x\n",
> Can you please decode bcdDevice into a decimal string?
>
> lsusb -v does this (bcdDevice: 0.03 for example) and in my experience
> it has generally matched up with how hardware manufacturers refer
> to their firmware.

Nevermind, %x should show bcd properly.  looks fine.

  reply	other threads:[~2018-03-24  1:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-24  0:33 [PATCH] USB: announce bcdDevice as well as idVendor, idProduct Benson Leung
2018-03-24  0:48 ` Andrew Chant
2018-03-24  1:08   ` Andrew Chant [this message]
2018-03-24  1:34     ` Benson Leung
2018-03-24  1:31 ` [PATCH v2] " Benson Leung
2018-03-24 16:06   ` Alan Stern
2018-03-24 17:43     ` Benson Leung
2018-03-24 17:40 ` [PATCH v3] " Benson Leung
2018-03-26 18:27   ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANVWZtGS9x-zLAgtV0rkgnBR0kLHTT0LYjKEreNy6qjkcC75PA@mail.gmail.com \
    --to=achant@google.com \
    --cc=bleung@chromium.org \
    --cc=bleung@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).