From: 유용수 <yongsuyoo0215@gmail.com>
To: Hans Petter Selasky <hps@selasky.org>
Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
mchehab@kernel.org
Subject: Re: [PATCH] media: dvb_ringbuffer : Fix a bug in dvb_ringbuffer.c
Date: Thu, 23 Jun 2022 18:11:40 +0900 [thread overview]
Message-ID: <CANXPkT73ssg6RRyfDtp7c_8sO60a-UT0-Y4S1_=D=M_mcLNN9g@mail.gmail.com> (raw)
In-Reply-To: <4883f0a7-6a1b-31bd-33fe-db8f6dcf73fa@selasky.org>
Dear Kieran Bingham
I sent E-mail again by Linux terminal by using the command " ... git
send-email .."
I believe that you will surely get the diff file.
Thank you
2022년 6월 22일 (수) 오후 10:12, Hans Petter Selasky <hps@selasky.org>님이 작성:
>
> Hi Kieran,
>
> The consumed variable should not be negative. This bug has been there
> since the beginning of the GIT at Linux from what I can see.
>
> +1
>
> --HPS
>
> From 108c6acb2cc4bc4314b96f6f254a04b2873a096c Mon Sep 17 00:00:00 2001
> From: YongSu Yoo <yongsuyoo0215@gmail.com>
> Date: Sun, 22 May 2022 04:53:12 +0000
> Subject: [PATCH] media: dvb_ringbuffer : Fix a bug in dvb_ringbuffer.c
>
> Signed-off-by:Yongsu Yoo <yongsuyoo0215@gmail.com>
>
> The function dvb_ringbuffer_pkt_next in
> /linux-next/drviers/media/dvb-core/dvb_ringbuffer.c,
> which searches the idx of the next valid packet in the ring
> buffer of the ca->slot_info[slot].rx_buffer at
> /linux-next/drivers/media/dvb-core/dvb_ca_en50221.c,
> has the following problem.
> In calculating the amounts of the consumed address of the ring
> buffer, if the read address(rbuf->pread) of the ring buffer is
> smaller than the idx, the amounts of the searched address
> should be (idx - rbuf->pread),
> whereas if the read address(rbuf->pread) of the ring buffer is
> larger than the idx, the amounts of the consumed address should
> be (idx - rbuf->pread + rbug->size). But there exists an
> incorrect logic that the rbug-size was not properly added on
> (idx - rbug->pread) in the later case. With this commit, we
> fixed this bug.
> ---
> drivers/media/dvb-core/dvb_ringbuffer.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-core/dvb_ringbuffer.c
> b/drivers/media/dvb-core/dvb_ringbuffer.c
> index d1d471af0636..7d4558de8e83 100644
> --- a/drivers/media/dvb-core/dvb_ringbuffer.c
> +++ b/drivers/media/dvb-core/dvb_ringbuffer.c
> @@ -335,7 +335,9 @@ ssize_t dvb_ringbuffer_pkt_next(struct
> dvb_ringbuffer *rbuf, size_t idx, size_t*
> idx = (idx + curpktlen + DVB_RINGBUFFER_PKTHDRSIZE) % rbuf->size;
> }
>
> - consumed = (idx - rbuf->pread) % rbuf->size;
> + consumed = (idx - rbuf->pread);
> + if (consumed < 0)
> + consumed += rbuf->size;
>
> while((dvb_ringbuffer_avail(rbuf) - consumed) >
> DVB_RINGBUFFER_PKTHDRSIZE) {
>
> --
> 2.17.1
next prev parent reply other threads:[~2022-06-23 9:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANXPkT6mYusYe8O0dbq3vW+24SsUZ19PqhOL+wLFRnbFXwu0Zg@mail.gmail.com>
[not found] ` <CANXPkT7nOhH+5bD0ycyRBT9FKQBBszCVuWkqp4tFtVRf2+8DFg@mail.gmail.com>
2022-06-22 11:39 ` [PATCH] media: dvb_ringbuffer : Fix a bug in dvb_ringbuffer.c 유용수
2022-06-22 12:33 ` Kieran Bingham
2022-06-22 13:12 ` Hans Petter Selasky
2022-06-23 9:11 ` 유용수 [this message]
2022-08-03 12:04 ` 유용수
2022-08-18 12:55 ` 유용수
2022-08-31 13:45 ` 유용수
2022-09-09 14:46 ` Hans Petter Selasky
2022-09-12 12:31 ` 유용수
2022-09-12 12:36 ` Hans Petter Selasky
2022-09-13 8:36 ` 유용수
2022-06-23 10:35 YongSu Yoo
2022-06-26 21:11 ` 유용수
2022-06-30 13:42 ` Hans Petter Selasky
2022-07-07 8:36 ` 유용수
2022-07-25 9:27 ` 유용수
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANXPkT73ssg6RRyfDtp7c_8sO60a-UT0-Y4S1_=D=M_mcLNN9g@mail.gmail.com' \
--to=yongsuyoo0215@gmail.com \
--cc=hps@selasky.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).