From: Zong Li <zong.li@sifive.com>
To: Joe Perches <joe@perches.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-riscv <linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] riscv: adjust the indent
Date: Sat, 8 Feb 2020 16:45:31 +0800 [thread overview]
Message-ID: <CANXhq0qL6oSsHOr+eFOYhBSAXPP5k=k0mwxEdHMGfUV9CSBHkA@mail.gmail.com> (raw)
In-Reply-To: <fdcfd8548707e2d6c61fc9739bc91c6720673c81.camel@perches.com>
On Fri, Feb 7, 2020 at 6:59 PM Joe Perches <joe@perches.com> wrote:
>
> On Fri, 2020-02-07 at 17:52 +0800, Zong Li wrote:
> > Adjust the indent to match Linux coding style.
>
> trivia:
>
> > diff --git a/arch/riscv/mm/kasan_init.c b/arch/riscv/mm/kasan_init.c
> []
> > @@ -86,7 +89,8 @@ void __init kasan_init(void)
> > unsigned long i;
> >
> > kasan_populate_early_shadow((void *)KASAN_SHADOW_START,
> > - (void *)kasan_mem_to_shadow((void *)VMALLOC_END));
> > + (void *)kasan_mem_to_shadow((void *)
> > + VMALLOC_END));
>
> could also remove an unnecessary (void *) as kasan_mem_to_shadow
> returns a void *
>
> kasan_populate_early_shadow((void *)KASAN_SHADOW_START,
> kasan_mem_to_shadow((void *)VMALLOC_END));
>
OK, I'll remove it in next version. Thanks.
prev parent reply other threads:[~2020-02-08 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 9:52 [PATCH 0/2] Fix the page table size of KASAN use Zong Li
2020-02-07 9:52 ` [PATCH 1/2] riscv: allocate a complete page size for each page table Zong Li
2020-02-07 9:52 ` [PATCH 2/2] riscv: adjust the indent Zong Li
2020-02-07 10:58 ` Joe Perches
2020-02-08 8:45 ` Zong Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANXhq0qL6oSsHOr+eFOYhBSAXPP5k=k0mwxEdHMGfUV9CSBHkA@mail.gmail.com' \
--to=zong.li@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).