From: Pramod Gurav <pramod.gurav@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support
Date: Wed, 31 Aug 2016 10:52:55 +0530 [thread overview]
Message-ID: <CANYu_0t0XpZPcq+Lh+z_CxERFFNkZKX9Rp8yttd7GdMcwe98Bg@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFraYWS+ZFLAhRfnhVEac6j8+oyGz6AVwnCgvEHxxvvLpQ@mail.gmail.com>
Thanks Ulf for the review.
On 29 August 2016 at 19:50, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 16 June 2016 at 14:35, Pramod Gurav <pramod.gurav@linaro.org> wrote:
<snip>
>> + platform_set_drvdata(pdev, msm_host);
>> +
>> + pm_runtime_set_active(&pdev->dev);
>> + pm_runtime_enable(&pdev->dev);
>
> I think you need to move these a bit earlier, before calling sdhci_add_host().
>
> Maybe it's just easier if you look at the sdhci-of-at91.c driver,
> which behaves nicely around runtime PM deployment. You can probably
> use the very similar code, except the ->runtime_suspend|resume()
> callbacks.
>
> And don't forget to deploy runtime PM support in the ->remove()
> callback as well, again sdhci-of-at91 is a good reference.
>
Will take a look at the said driver and do necessary changes and repost.
Thanks again.
Regards,
Pramod
next prev parent reply other threads:[~2016-08-31 5:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 12:35 [PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support Pramod Gurav
2016-08-29 8:59 ` Pramod Gurav
2016-08-29 14:20 ` Ulf Hansson
2016-08-31 5:22 ` Pramod Gurav [this message]
2016-09-08 7:47 ` Adrian Hunter
2016-09-08 8:00 ` Adrian Hunter
2016-09-01 14:17 Pramod Gurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANYu_0t0XpZPcq+Lh+z_CxERFFNkZKX9Rp8yttd7GdMcwe98Bg@mail.gmail.com \
--to=pramod.gurav@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).