From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756463AbcILHrK (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Sep 2016 03:47:10 -0400
Received: from mail-yb0-f176.google.com ([209.85.213.176]:34736 "EHLO
        mail-yb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755607AbcILHrI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Sep 2016 03:47:08 -0400
MIME-Version: 1.0
In-Reply-To: <57D28847.8070308@codeaurora.org>
References: <20160901142335.2396-1-pramod.gurav@linaro.org> <57D28847.8070308@codeaurora.org>
From: Pramod Gurav <pramod.gurav@linaro.org>
Date: Mon, 12 Sep 2016 13:17:07 +0530
Message-ID: <CANYu_0tviS8tiG1Zskk2XHnXQ=7CJKH_gcCaUOoT+kMh-2oTCQ@mail.gmail.com>
Subject: Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support
To: "Tummala, Sahitya" <stummala@codeaurora.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9 September 2016 at 15:30, Tummala, Sahitya <stummala@codeaurora.org> wrote:
> Hi Pramod,
<snip>
>> +       ret = clk_prepare_enable(msm_host->clk);
>> +       if (ret) {
>> +               dev_err(dev, "clk_enable failed: %d\n", ret);
>
> A minor comment - Both error prints related to clock enable are same. Better
> to print the clock name as well to know which clock enable got failed.
>

Thanks Sahitya for comments. Will take care of this in next version.
>> +               return ret;
>> +       }