From: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
To: Rick Altherr <raltherr@google.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH v1 2/2] hw_random: timeriomem_rng: Allow setting RNG quality from platform data
Date: Thu, 18 May 2017 11:13:29 +0530 [thread overview]
Message-ID: <CANc+2y4vg1F2+y98ijoR1Ve_2u+zpChN3OXxn+6uLebVLcDp6Q@mail.gmail.com> (raw)
In-Reply-To: <20170517222911.9295-2-raltherr@google.com>
Hi Rick,
Minor comment below.
On 18 May 2017 at 03:59, Rick Altherr <raltherr@google.com> wrote:
> When a hw_random device's quality is non-zero, it will automatically be
> used to fill the kernel's entropy pool. Since timeriomem_rng is used by
> many different devices, the quality needs to be provided by platform
> data or device tree.
>
> Signed-off-by: Rick Altherr <raltherr@google.com>
> ---
>
> drivers/char/hw_random/timeriomem-rng.c | 7 +++++++
> include/linux/timeriomem-rng.h | 3 +++
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/char/hw_random/timeriomem-rng.c b/drivers/char/hw_random/timeriomem-rng.c
> index a0faa5f05deb..03ff5483d865 100644
> --- a/drivers/char/hw_random/timeriomem-rng.c
> +++ b/drivers/char/hw_random/timeriomem-rng.c
> @@ -151,8 +151,15 @@ static int timeriomem_rng_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "missing period\n");
> return -EINVAL;
> }
> +
> + if (!of_property_read_u32(pdev->dev.of_node,
> + "quality", &i))
> + priv->rng_ops.quality = i;
> + else
> + priv->rng_ops.quality = 0;
> } else {
> period = pdata->period;
> + priv->rng_ops.quality = pdata->quality;
> }
>
> priv->period = ns_to_ktime(period * NSEC_PER_USEC);
> diff --git a/include/linux/timeriomem-rng.h b/include/linux/timeriomem-rng.h
> index 46eb27ddbfab..320f743bf06b 100644
> --- a/include/linux/timeriomem-rng.h
> +++ b/include/linux/timeriomem-rng.h
> @@ -13,4 +13,7 @@ struct timeriomem_rng_data {
>
> /* measures in usecs */
> unsigned int period;
> +
> + /* bits of entropy per 1000 bits read */
Your dt-bindings patch says 'entropy per 1024 bits'. Please be consistent.
> + unsigned int quality;
> };
> --
> 2.13.0.303.g4ebf302169-goog
>
Regards,
PrasannaKumar
next prev parent reply other threads:[~2017-05-18 5:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 22:29 [PATCH v1 1/2] dt-bindings: timeriomem_rng: Add entropy quality property Rick Altherr
2017-05-17 22:29 ` [PATCH v1 2/2] hw_random: timeriomem_rng: Allow setting RNG quality from platform data Rick Altherr
2017-05-18 5:43 ` PrasannaKumar Muralidharan [this message]
2017-05-23 14:06 ` [PATCH v1 1/2] dt-bindings: timeriomem_rng: Add entropy quality property Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANc+2y4vg1F2+y98ijoR1Ve_2u+zpChN3OXxn+6uLebVLcDp6Q@mail.gmail.com \
--to=prasannatsmkumar@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=raltherr@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).