From: John Stultz <john.stultz@linaro.org>
To: linus.walleij@linaro.org, Anders Roxell <anders.roxell@linaro.org>
Cc: lgirdwood@gmail.com, broonie@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
jmkrzyszt@gmail.com, shc_work@mail.ru, haojian.zhuang@gmail.com,
aaro.koskinen@iki.fi, rppt@linux.vnet.ibm.com,
robert.jarzmik@free.fr, philipp.zabel@gmail.com,
zonque@gmail.com, marc.zyngier@arm.com, jacopo@jmondi.org,
geert+renesas@glider.be, rmk+kernel@armlinux.org.uk,
Tom Gall <tom.gall@linaro.org>
Subject: Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only
Date: Fri, 28 Sep 2018 16:32:33 -0700 [thread overview]
Message-ID: <CANcMJZBAerypZGFV+Bc_+J34+8zt7t6+6vnJof7x7PC9bFGq8w@mail.gmail.com> (raw)
In-Reply-To: <20180906122436.25610-1-linus.walleij@linaro.org>
On Thu, Sep 6, 2018 at 6:01 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> As we augmented the regulator core to accept a GPIO descriptor instead
> of a GPIO number, we can augment the fixed GPIO regulator to look up
> and pass that descriptor directly from device tree or board GPIO
> descriptor look up tables.
>
> Some boards just auto-enumerate their fixed regulator platform devices
> and I have assumed they get names like "fixed-regulator.0" but it's
> pretty hard to guess this. I need some testing from board maintainers to
> be sure. Other boards are straight forward, using just plain
> "fixed-regulator" (ID -1) or "fixed-regulator.1" hammering down the
> device ID.
Hey Linus,
Anders recently noted a regression in -next when running HiKey,
where USB fails to function. I took a look and could reproduce this
as well, and after some unsuccessful muddling about in the usb
changes, I bisected it down to your commit here (specifically
efdfeb079cc3 in -next).
I'm not sure exactly why this would cause trouble, but I suspect it
has something to do w/ the cable-detect OTG to host-hub switch on the
HiKey.
Anyway, I just wanted to raise this with you so it can get sorted out
before that patch hits mainline.
thanks
-john
next prev parent reply other threads:[~2018-09-28 23:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 12:24 [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only Linus Walleij
2018-09-10 17:01 ` Janusz Krzysztofik
2018-09-11 16:06 ` Mike Rapoport
2018-09-28 23:32 ` John Stultz [this message]
2018-09-29 17:38 ` Linus Walleij
2018-10-01 18:53 ` Leonard Crestez
2018-10-01 20:16 ` Linus Walleij
2018-10-01 20:37 ` Fabio Estevam
2018-10-01 20:48 ` Linus Walleij
[not found] ` <CGME20181011090112eucas1p286d8c1edfc1a2a207d8a11c5ad7eb20e@eucas1p2.samsung.com>
2018-10-11 9:01 ` Marek Szyprowski
2018-10-11 9:29 ` Linus Walleij
2018-10-11 9:46 ` Marek Szyprowski
2018-10-11 13:15 ` Mark Brown
2018-10-11 15:00 ` Jon Hunter
2018-10-11 15:34 ` Marcel Ziswiler
2018-10-11 17:47 ` Linus Walleij
2018-10-12 9:43 ` Marcel Ziswiler
2018-10-12 10:39 ` Jon Hunter
2018-10-12 10:43 ` Russell King - ARM Linux
2018-10-12 11:03 ` Linus Walleij
2018-10-12 11:43 ` Marcel Ziswiler
2018-10-12 12:59 ` Russell King - ARM Linux
2018-10-12 13:13 ` Marcel Ziswiler
2018-10-12 16:57 ` Mark Brown
2018-10-12 13:58 ` Andy Shevchenko
2018-10-12 16:17 ` Mark Brown
2018-10-11 17:45 ` Linus Walleij
2018-10-12 10:25 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANcMJZBAerypZGFV+Bc_+J34+8zt7t6+6vnJof7x7PC9bFGq8w@mail.gmail.com \
--to=john.stultz@linaro.org \
--cc=aaro.koskinen@iki.fi \
--cc=anders.roxell@linaro.org \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=haojian.zhuang@gmail.com \
--cc=jacopo@jmondi.org \
--cc=jmkrzyszt@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=philipp.zabel@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robert.jarzmik@free.fr \
--cc=rppt@linux.vnet.ibm.com \
--cc=shc_work@mail.ru \
--cc=tom.gall@linaro.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).