From: Pi-Hsun Shih <pihsun@chromium.org>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: Properly detect /* */ style SPDX header.
Date: Tue, 12 Feb 2019 16:47:03 +0800 [thread overview]
Message-ID: <CANdKZ0dEFr5TAuat16sEKm=B3bRa5nqBvR3OCM=hzKGcBQKbJA@mail.gmail.com> (raw)
In-Reply-To: <511a36863af02aec12fd77657b0ca199e023f319.camel@perches.com>
On Fri, Feb 1, 2019 at 12:54 AM Joe Perches <joe@perches.com> wrote:
>
> On Thu, 2019-01-31 at 17:56 +0800, Pi-Hsun Shih wrote:
> > Currently for a header line "/* SPDX-License-Identifier: GPL-2.0 */",
> > only the part starting from "SPDX-" is passed to spdxcheck.py, and cause
> > false warning. Fix this by passing the whole line to spdxcheck.py
> > instead.
>
> Thanks but I submitted a different patch:
>
> https://lore.kernel.org/lkml/8b02899853247a2c67669561761f354dd3bd110e.camel@perches.com/
>
I tried your patch, but when running checkpatch.pl on
https://patchwork.kernel.org/patch/10790203/, I still get:
WARNING: 'SPDX-License-Identifier: GPL-2.0 */' is not supported in LICENSES/...
#75: FILE: drivers/remoteproc/mtk_common.h:1:
+/* SPDX-License-Identifier: GPL-2.0 */
Feels that these two patches fix different issues.
prev parent reply other threads:[~2019-02-12 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 9:56 [PATCH] checkpatch: Properly detect /* */ style SPDX header Pi-Hsun Shih
2019-01-31 16:54 ` Joe Perches
2019-02-12 8:47 ` Pi-Hsun Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANdKZ0dEFr5TAuat16sEKm=B3bRa5nqBvR3OCM=hzKGcBQKbJA@mail.gmail.com' \
--to=pihsun@chromium.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).