From: Chuhong Yuan <hslester96@gmail.com>
To: "Cao, Bingbu" <bingbu.cao@intel.com>
Cc: "Zhi, Yong" <yong.zhi@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Akihiro Tsukada <tskd08@gmail.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: pci: Use dev_get_drvdata where possible
Date: Wed, 24 Jul 2019 09:23:41 +0800 [thread overview]
Message-ID: <CANhBUQ1uODBgoiHk8nrMrtdJ2E-C70PgRJm7zLkWGoQDovKpzg@mail.gmail.com> (raw)
In-Reply-To: <EE45BB6704246A4E914B70E8B61FB42A15C77041@SHSMSX104.ccr.corp.intel.com>
On Tue, Jul 23, 2019 at 10:39 PM Cao, Bingbu <bingbu.cao@intel.com> wrote:
>
>
>
> ________________________
> BRs,
> Bingbu Cao
>
>
> -----Original Message-----
> From: Chuhong Yuan <hslester96@gmail.com>
> Sent: Tuesday, July 23, 2019 7:50 PM
> Cc: Zhi, Yong <yong.zhi@intel.com>; Sakari Ailus <sakari.ailus@linux.intel.com>; Cao, Bingbu <bingbu.cao@intel.com>; Mauro Carvalho Chehab <mchehab@kernel.org>; Akihiro Tsukada <tskd08@gmail.com>; linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; Chuhong Yuan <hslester96@gmail.com>
> Subject: [PATCH] media: pci: Use dev_get_drvdata where possible
>
> Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> drivers/media/pci/intel/ipu3/ipu3-cio2.c | 3 +--
> drivers/media/pci/pt1/pt1.c | 6 ++----
> drivers/media/pci/pt3/pt3.c | 6 ++----
> 3 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> index c1d133e17e4b..50a34bcd4d14 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> @@ -2000,8 +2000,7 @@ static int __maybe_unused cio2_suspend(struct device *dev)
>
> static int __maybe_unused cio2_resume(struct device *dev) {
> - struct pci_dev *pci_dev = to_pci_dev(dev);
> - struct cio2_device *cio2 = pci_get_drvdata(pci_dev);
> + struct cio2_device *cio2 = dev_get_drvdata(dev);
>
> Thanks for your patch.
> I think using pci_get_drvdata() here mainly make a pair with the pci_set_drvdata() in probe.
Thanks for your reply.
I will change pci_set_drvdata() to dev_set_drvdata() in the next
version to keep their consistency.
>
> int r = 0;
> struct cio2_queue *q = cio2->cur_queue;
>
> diff --git a/drivers/media/pci/pt1/pt1.c b/drivers/media/pci/pt1/pt1.c index e51c80bc4646..72b191cfeb54 100644
> --- a/drivers/media/pci/pt1/pt1.c
> +++ b/drivers/media/pci/pt1/pt1.c
> @@ -1217,8 +1217,7 @@ static void pt1_i2c_init(struct pt1 *pt1)
>
> static int pt1_suspend(struct device *dev) {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct pt1 *pt1 = pci_get_drvdata(pdev);
> + struct pt1 *pt1 = dev_get_drvdata(dev);
>
> pt1_init_streams(pt1);
> pt1_disable_ram(pt1);
> @@ -1230,8 +1229,7 @@ static int pt1_suspend(struct device *dev)
>
> static int pt1_resume(struct device *dev) {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct pt1 *pt1 = pci_get_drvdata(pdev);
> + struct pt1 *pt1 = dev_get_drvdata(dev);
> int ret;
> int i;
>
> diff --git a/drivers/media/pci/pt3/pt3.c b/drivers/media/pci/pt3/pt3.c index 7a7afae4c84c..c0bc86793355 100644
> --- a/drivers/media/pci/pt3/pt3.c
> +++ b/drivers/media/pci/pt3/pt3.c
> @@ -626,8 +626,7 @@ static void pt3_cleanup_adapter(struct pt3_board *pt3, int index)
>
> static int pt3_suspend(struct device *dev) {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct pt3_board *pt3 = pci_get_drvdata(pdev);
> + struct pt3_board *pt3 = dev_get_drvdata(dev);
> int i;
> struct pt3_adapter *adap;
>
> @@ -646,8 +645,7 @@ static int pt3_suspend(struct device *dev)
>
> static int pt3_resume(struct device *dev) {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct pt3_board *pt3 = pci_get_drvdata(pdev);
> + struct pt3_board *pt3 = dev_get_drvdata(dev);
> int i, ret;
> struct pt3_adapter *adap;
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-07-24 1:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 11:50 [PATCH] media: pci: Use dev_get_drvdata where possible Chuhong Yuan
2019-07-23 14:39 ` Cao, Bingbu
2019-07-24 1:23 ` Chuhong Yuan [this message]
2019-07-25 9:14 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANhBUQ1uODBgoiHk8nrMrtdJ2E-C70PgRJm7zLkWGoQDovKpzg@mail.gmail.com \
--to=hslester96@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tskd08@gmail.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).