From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4BB7C433FE for ; Mon, 28 Nov 2022 13:49:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232034AbiK1NtU (ORCPT ); Mon, 28 Nov 2022 08:49:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232065AbiK1NtS (ORCPT ); Mon, 28 Nov 2022 08:49:18 -0500 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A5B61E5 for ; Mon, 28 Nov 2022 05:49:16 -0800 (PST) Received: by mail-io1-xd2c.google.com with SMTP id e189so7584524iof.1 for ; Mon, 28 Nov 2022 05:49:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5WWumrqiTDYq5uOZBAPJFRzs6vcelTvSCtUZimwYyKk=; b=JaLWK4hY8LgNiPiKh9CCSm+56V2c4Rm7Q59ef1OdxUY5vA0ZNzGYJh8zBSh2Cg6W64 eEKR+qLTv/MU1cSh80KUT8bP9gfduZ5u5xWY/RRkgkx433VnWoMLQFoAUQzLsnHsYWJW YGsPYd+Hr+yIoAkDDGPvqs9pyqr1YJYebXF1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5WWumrqiTDYq5uOZBAPJFRzs6vcelTvSCtUZimwYyKk=; b=68mGE/r0APWvpTMFrhdNa8NK19+z2W3A+xMsEPcTC6g7ydwI3KKpcfiXAO2vlgGZHo wIHxPRYxOiDs7W1VuKC4ipzmx3MntYl1zVqpLQpNorM1e5NeNoGZfJN/HRW2aUa+RtkX g1EzuKYCVMLByRkUDdItMYX6y3x8oo7uXC7OE8ZviJrqJHJdYTf3epknyDXIHupgwH/l Qh+ky+NX3qp9tpyqU+lNvMnRi7HajPzNFSy9fMRu1CyDeEme8fmllfnQeTUjofi/XJnn 6+fZoPYSkZOC1a/8RrrixLnN8Qy8sgSdtbBPKy21Nq5pwikkxNgkqtRPP4JoYLiPXSdv p2LA== X-Gm-Message-State: ANoB5pk7Hite2cux1hJ3BEXgQQEK8D0ytTEk9OBKUvWoNYrrzszCqF6a XBUWOw6gNfOCDlVXfg9tZ4PT071rUZgyfZr1 X-Google-Smtp-Source: AA0mqf7hYXLiXkUQ/0/WosMgqvS1Pj1RHQdXb3IX/E7/tVcSfZUv/lX7pQ5EPOydZoTPHWTw09bmBw== X-Received: by 2002:a6b:6d0d:0:b0:6c4:ad4d:b23a with SMTP id a13-20020a6b6d0d000000b006c4ad4db23amr13315493iod.2.1669643355600; Mon, 28 Nov 2022 05:49:15 -0800 (PST) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com. [209.85.166.45]) by smtp.gmail.com with ESMTPSA id v4-20020a92ab04000000b00302a7165d9bsm3796626ilh.53.2022.11.28.05.49.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 05:49:14 -0800 (PST) Received: by mail-io1-f45.google.com with SMTP id g26so6916605iob.11 for ; Mon, 28 Nov 2022 05:49:13 -0800 (PST) X-Received: by 2002:a02:ccfb:0:b0:373:9d0a:33a0 with SMTP id l27-20020a02ccfb000000b003739d0a33a0mr1950090jaq.286.1669643353517; Mon, 28 Nov 2022 05:49:13 -0800 (PST) MIME-Version: 1.0 References: <20221128-mt8173-afe-v1-0-70728221628f@chromium.org> In-Reply-To: From: Ricardo Ribalda Date: Mon, 28 Nov 2022 14:49:02 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ASoC: mediatek: mt8173: Enable IRQ when pdata is ready To: Mark Brown Cc: AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, alsa-devel@alsa-project.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Mon, 28 Nov 2022 at 14:34, Mark Brown wrote: > > On Mon, Nov 28, 2022 at 02:17:53PM +0100, AngeloGioacchino Del Regno wrote: > > > This commit needs a Fixes tag, as this is indeed a fix.... kexec isn't anything > > new, so all kernel versions are affected by this bug. > > Fixes tags are a nice to have, they're not 100% a requirement - they're > a lot more useful when they're fixing a bug that was introduced rather > than just something that never worked. I do not have any strong opinion here. If you want to add the tag. It should be: Fixes: ee0bcaff109f ("ASoC: mediatek: Add AFE platform driver") Let me know if I shall resend. Thanks! -- Ricardo Ribalda