linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Ben Moore <benmoore422@gmail.com>
Cc: Willy Tarreau <w@1wt.eu>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [PATCHv2 TRIVIAL] auxdisplay: remove unnecessary braces
Date: Sat, 6 Oct 2018 22:59:22 +0200	[thread overview]
Message-ID: <CANiq72=9o+=4prkUNCogmz7D9vqNJj0fUZ93aBRfJzZs_Ni38w@mail.gmail.com> (raw)
In-Reply-To: <20180923172543.5391-1-benmoore422@gmail.com>

Hi Ben,

On Sun, Sep 23, 2018 at 7:26 PM <benmoore422@gmail.com> wrote:
> I have removed some unnecessary braces from if statements.
> As well as inspecting the other driverfiles for similar
> style issues.

Thanks for the new version!

> -       if (err) {
> +       if (err)
>                 dft_brightness = MAX_BRIGHTNESS;
> -       } else if (dft_brightness > MAX_BRIGHTNESS) {
> +       else if (dft_brightness > MAX_BRIGHTNESS) {

This one breaks the braces-if-the-other-branch-has-them that Geert
told you about:

  https://www.kernel.org/doc/html/latest/process/coding-style.html#placing-braces-and-spaces

> -               if (byte & 1) {
> +               if (byte & 1)
>                         set_bit(LCD_BIT_DA, bits);
> -               } else {
> +               else
>                         clear_bit(LCD_BIT_DA, bits);
> -               }

This one seems fine.

Cheers,
Miguel

      reply	other threads:[~2018-10-06 20:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-23 17:25 [PATCH] [PATCHv2 TRIVIAL] auxdisplay: remove unnecessary braces benmoore422
2018-10-06 20:59 ` Miguel Ojeda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANiq72=9o+=4prkUNCogmz7D9vqNJj0fUZ93aBRfJzZs_Ni38w@mail.gmail.com' \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=benmoore422@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).