From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B35C25B08 for ; Wed, 17 Aug 2022 20:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241859AbiHQU4h (ORCPT ); Wed, 17 Aug 2022 16:56:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241761AbiHQU4e (ORCPT ); Wed, 17 Aug 2022 16:56:34 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86DACA927F; Wed, 17 Aug 2022 13:56:33 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id z72so2766129iof.12; Wed, 17 Aug 2022 13:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=2F8UapFM6fvTc5fGCMprtfZuN5LHlZVrraMyXumfVqE=; b=LbgMGsGKphl7X2/Jn0u5eMcUeY0mew1lHqKEqfLaBcD42X17Re8z5rpOQYmW5Vtdo9 tsbQAaIFqFo5BvaBx68dsfnuUwQq92cWSEI/zxlhcsjD+kx3hydeBmsw4hEX1VPxHNvw tKWoDZfnYemoNlsbZC7T5Vg/Y7CgUmUyqnX6JuDfQU0jfZ/7c2KoYLaCTzWOhZsNLkVP vqeWW/J4WU3sDEN/7KdViU1V3Y9L/UKbFfVhaY7IJ3DWdEMKtg8uJdqyaFYcyhIYcwBa fVXnH6CAm8WsCTJgnXY6K1pGRxlZiwyjtMG1yPSDD/ZtE6bHaFuxIcURQjWPG9D+DslS ipSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=2F8UapFM6fvTc5fGCMprtfZuN5LHlZVrraMyXumfVqE=; b=mX/m7Rk10kWwjaZUStBjmmTzu9xYgrTmgaYkbXjiXyMTiSB2DTDb2kS1hDSRWqrH4G 9JKcGtO/axXs21B7rBpxw6N7rXv7EF1jOYful0wl09lAh8DNqozhEwuMbl05d4V7es2+ 3SsEJy7F5qJR4pkfptXWsV0tA7siOXjam/WshiZdeq+kjhDOmaXYi4Q/FC2GI6xMN2Ti oHo5Fg0FpOsTHGneaK6Mc7IKMmo4nzSxfpAEzh3JHu03oQdbSCXqvS+WOplVxvlv8LMs WCusQkNXbpT+5viiYV8j0RWAzPVLo7p3xkDt6dY9lx1BpfNJ98om5JcpNluerZDQOFJV oS9g== X-Gm-Message-State: ACgBeo0R1EOoZuYZI2iTEz2/CngqZXnat7lGtVu0meSTWN7+aT2CV3g0 QZlmXpA4XOuArOXeHnm6VlSCjbrBlVrZQtyIgoU= X-Google-Smtp-Source: AA6agR7W0/vJMmLEu2GKK6hHojDe0NnOQN0sm9gqWwqOLGfYNe/j8D+Y8j9wEt1Kx9LD5aIinElIOM+NZfs9EfUUXfw= X-Received: by 2002:a5d:8618:0:b0:684:6469:596b with SMTP id f24-20020a5d8618000000b006846469596bmr10939iol.177.1660769793009; Wed, 17 Aug 2022 13:56:33 -0700 (PDT) MIME-Version: 1.0 References: <20220805154231.31257-1-ojeda@kernel.org> <20220805154231.31257-24-ojeda@kernel.org> <202208171324.FB04837@keescook> In-Reply-To: <202208171324.FB04837@keescook> From: Miguel Ojeda Date: Wed, 17 Aug 2022 22:56:21 +0200 Message-ID: Subject: Re: [PATCH v9 23/27] Kbuild: add Rust support To: Kees Cook Cc: Miguel Ojeda , Linus Torvalds , Greg Kroah-Hartman , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, patches@lists.linux.dev, Jarkko Sakkinen , Alex Gaynor , Finn Behrens , Adam Bratschi-Kaye , Wedson Almeida Filho , Michael Ellerman , Sven Van Asbroeck , Gary Guo , Boris-Chengbiao Zhou , Boqun Feng , Douglas Su , Dariusz Sosnowski , Antonio Terceiro , Daniel Xu , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Martin Rodriguez Reboredo , Masahiro Yamada , Michal Marek , Nick Desaulniers , linux-kbuild@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2022 at 10:26 PM Kees Cook wrote: > > It'd be nice to split this up into maybe per-target patches, but given > how long this has been getting developed, I'd prefer to avoid blocking > on that, and just get this series landed so we can move to incremental > fixes/additions. When I started the series, I considered several approaches, and in the end opted for "setup as much as possible before the flag-patch that enables the Kbuild support", which was simple, though indeed the Kbuild patch remained fairly big. Then some people commented on that patch over several versions, so I kept the simple strategy :) What I can look into is moving the optional targets out of this patch, putting them after the "flag-patch", since they may be considered "additional features" anyway. In fact, for the trimming down in v9, I thought about removing them entirely. It will not change things too much, since they are small, but it may help. For v9 I nevertheless attempted to simplify this patch by doing the "move all new, big files to their own patch" (see my reply at [1]), so it is fairly smaller than in previous versions. [1] https://lore.kernel.org/lkml/CANiq72nzOQSd2vsh2_=0YpGNpY=7agokbgi_vBc5_GF4-02rsA@mail.gmail.com/ Cheers, Miguel