From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1629C433FE for ; Sun, 2 Oct 2022 19:22:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbiJBTWc (ORCPT ); Sun, 2 Oct 2022 15:22:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbiJBTWa (ORCPT ); Sun, 2 Oct 2022 15:22:30 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F88929813; Sun, 2 Oct 2022 12:22:29 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id q83so6782834iod.7; Sun, 02 Oct 2022 12:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=lHVZ8hajxDUrSE+HbGsQ29juLRzmP+3OYmThWC7Wxv8=; b=KQ4vBaSlYIP4u1I/BPdJgxVVFPDaagY/zt1RxWx9HY+nT96NppjnXfubKBNOpe6LPq BP7RuWgMB1BCdYjrb2NfTJfBCCv9ue7xXblHxtvMR5jETp5PgzTRU0XzgL4lvXFeTbVl 7RmZhD3gCUzzuyGTVPrd+uDXsp/ubrZVv4j6H9ATwf86Hy8Q6WsLZgrTSh/Yf3z/yWPe 7Je3R45+zUMfK5XOYuDs7tEeIHBiTbsNH9+sLF/EHB5loe9Ms+YaUT4TfnWuzOPzth+7 jpo8GPdJv4I1bb5LVUQTlCujErWqJ4rR5zfbIQbcuwULQi0J0yiXXznxuzI8aOerHfvz R7Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=lHVZ8hajxDUrSE+HbGsQ29juLRzmP+3OYmThWC7Wxv8=; b=loxuUGVDuQGu11lnYbJvWdyg3cdS3K7e9Ir12nH/VUQsQcvstAJyFH+6kmPczZTzjS WPYBJv8cux3yWlkxrpndmYv/BRx7XvSaMH9ymHeuOufDUxHhbVdKvsJrwUd7Jwo/BQmj la/mfzvcKyQGZk9EaaQHAsJeGtHokIRCvzTLE5tX4SdNmPQ3qZLD7Nitb4l/xTBvquCf mscCECM/HfBmoEDDVSdir3TvET7+x8g6pLfoA1s2hogmJTX24jdj7ho7DtlMN/KtjGlY ddrifFRdxHF7IUEMZkIws+sDbqvhHqQmZJ8WJlqZA2eTpPsdC6owVDmNy12wFOmgaQKX YtFg== X-Gm-Message-State: ACrzQf1gJabFIG673sqKYxVwJ/y4aGn60tKFoR39a13N7e4c22r7edi2 ZyUE0O5KtRVBcpihZEnm1K1pDE5AMIeLfzejBlw= X-Google-Smtp-Source: AMsMyM7nDCFxZShox/Abpgr4yMv7bbmXQ24CAd47DFbld3g8JcZrMuD7UAMmEunW/Izg3puGwlGPjCYfYgZqRA1EzB0= X-Received: by 2002:a05:6602:2a45:b0:6a4:43dc:40ef with SMTP id k5-20020a0566022a4500b006a443dc40efmr7435527iov.64.1664738548708; Sun, 02 Oct 2022 12:22:28 -0700 (PDT) MIME-Version: 1.0 References: <20221001202836.3110985-1-masahiroy@kernel.org> In-Reply-To: <20221001202836.3110985-1-masahiroy@kernel.org> From: Miguel Ojeda Date: Sun, 2 Oct 2022 21:22:17 +0200 Message-ID: Subject: Re: [PATCH] docs: bump minimal GNU Make version to 3.82 To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Linus Torvalds , linux-kernel@vger.kernel.org, Nick Desaulniers , Miguel Ojeda , Jonathan Corbet , linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 1, 2022 at 10:30 PM Masahiro Yamada wrote: > > The error message looks weird, but the reason is that the 'private' > keyword is only supported since GNU Make 3.82. Sorry about that. Indeed, it was added in 3.82 [1,2]. Given GCC 5.1 (the current minimum) was released 5 years later, I guess it is OK to increase it. Reviewed-by: Miguel Ojeda [1] https://git.savannah.gnu.org/cgit/make.git/commit/?id=5b4d419476e9fbda8ea26017f6ec15956d103ed9 [2] https://git.savannah.gnu.org/cgit/make.git/tree/ChangeLog?h=3.82#n814 Cheers, Miguel