From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 725D4C433EF for ; Mon, 14 Feb 2022 12:12:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352698AbiBNMMp (ORCPT ); Mon, 14 Feb 2022 07:12:45 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232654AbiBNMMn (ORCPT ); Mon, 14 Feb 2022 07:12:43 -0500 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E490E48E7A; Mon, 14 Feb 2022 04:12:35 -0800 (PST) Received: by mail-il1-x130.google.com with SMTP id z18so12145848iln.2; Mon, 14 Feb 2022 04:12:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I63uXQLULxgIp+fxBBldhXZGMfrAe8iy9NyQfbBqJO0=; b=JZBkvSicr6NtfK98ljz2alqvymXQ0GUvDMoAHYM8+T6uTTo6eGknpXg4G/hXbfa4J6 i9FjhKAXKmSxBx3kC/ZhkVWFWKA7jYsYruEVp5Dpei0Z/LMWn69PIt/6U9iBK4ryufb0 q/JP0zQ67doDCcrtc1OQxa6Tf+m4T03mKevIVCx6P2OvVIAEXvnhBzN5qnNMxc6NFAuN DgKMWnQW7JgwTvayVkKG2k+Gia6oL+OwF6BcLHs8Q7MlwEEJcH0W0zMKnu4iEO/pZa6h aiK3179PUSbIAY6rcmtq41FqJoXeTK9Q/QoUaz1MyM4T3QPUyVSTiSWqNO9TvqEOmvNi mxqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I63uXQLULxgIp+fxBBldhXZGMfrAe8iy9NyQfbBqJO0=; b=GZs24v5ZusgtHU4kpxXAplTb9NVaFXh8tALqDof/VQPSJI2v44KXFX0opd8Q3m4RCQ +ahVWkFKuoG+MenPVbH0Yv7yFgtbWi4PvK1ZfhxPksn+smwK5CyyWdUziVmvHWj7MjU6 Dnhw3H5eTLCIMIIWoytQDTonW3Ky3tyy3YCaAIqpuTGrh3gy5XuslcDbN3NtqRGNIWqI JZq7BKU1EclYnxTKmE6DJDNuemRFao1FabDHv7WHkzn3jmPsOR05SBPV+RnPUqwKAbYr I5iwkIxFSmm6O/kO561QED7C5f4wGrPj4r9eaTHT5xI0bOxMWMPnfwwKk+pAsTb7Ml3J HYEg== X-Gm-Message-State: AOAM5312nIzJdqKhuToGNVdduA3B7x2JpLX8+UL6xyu9x+3/iiYezCeG kEBHu9R2JlKxA0+ckqtAdOeN7ik43qDfJq0cjJY= X-Google-Smtp-Source: ABdhPJxP0qVSdni91fTkhLPpuqdXa4tkmKCt6AvlGTNRlON0vuZGUCaWQMGTu6DhK93bwZFFtrS8Zo/9aCY1r6Dg5OU= X-Received: by 2002:a92:c248:: with SMTP id k8mr3453071ilo.321.1644840755343; Mon, 14 Feb 2022 04:12:35 -0800 (PST) MIME-Version: 1.0 References: <20220212130410.6901-1-ojeda@kernel.org> <20220212130410.6901-13-ojeda@kernel.org> In-Reply-To: From: Miguel Ojeda Date: Mon, 14 Feb 2022 13:12:24 +0100 Message-ID: Subject: Re: [PATCH v4 12/20] vsprintf: add new `%pA` format specifier To: Rasmus Villemoes Cc: Andy Shevchenko , Miguel Ojeda , Linus Torvalds , Greg Kroah-Hartman , rust-for-linux , linux-kernel , Gary Guo , Alex Gaynor , Wedson Almeida Filho , Petr Mladek , Steven Rostedt , Sergey Senozhatsky Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 14, 2022 at 11:52 AM Rasmus Villemoes wrote: > > I think the point is for vsnprintf() to call (back) into Rust code. Indeed, this is the case. > That said, I don't like the !CONFIG_RUST version to return NULL, that > will surely crash moments later. > > So I prefer something like > > [rust.h] > // no CONFIG_RUST conditional > +char *rust_fmt_argument(char* buf, char* end, void *ptr); > > [vsprintf.c] > + case 'A': > + if (IS_ENABLED(CONFIG_RUST)) > + return rust_fmt_argument(buf, end, ptr); > + else > + return string_nocheck(buf, end, "[%pA in non-Rust > code?!]", default_str_spec); Sounds good. Or perhaps simply `break` and let it print the pointer (to be consistent with `g` case and non-error `e` case). Cheers, Miguel