From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3A85C433EF for ; Wed, 4 May 2022 19:26:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376857AbiEDTaM (ORCPT ); Wed, 4 May 2022 15:30:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357259AbiEDTaH (ORCPT ); Wed, 4 May 2022 15:30:07 -0400 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAE7A4A90C; Wed, 4 May 2022 12:26:30 -0700 (PDT) Received: by mail-il1-x12d.google.com with SMTP id h11so1504054ila.5; Wed, 04 May 2022 12:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=faKNM+qwcArkJmPdQKZUatJOcPW6asWisYRgltgA+bM=; b=VrLn4DXjigrD/Rraqf7CcvlUwmR7BblTWy83YVocIBLYRtnQrXbss03vXrg9mQL2JW JheLYxPbVecLLCpGdrFWJ32cImulwZiUJy/UhNWxROYuDL2Th2jbPXLSVX3EZapQ846X 1yoFSHf/bA+P9hUV6to0Q30YZUdUDaLV/iyc7O9JEj3F2xOnh1b1zyV1gQFTAorEuUvj lYS/Y3xdAQh7TtWahQLT5kNe/ISqAEUt5EqSCtmU4MG3cGa5oLweRn5ihIBVeUWcUy5V TVpjBmLGHnx9vXtXGATV6pgXuOfCRGsOJdpYUGEhZ3PoJDO4P4qHU2/80bxp+heODJKA 0hsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=faKNM+qwcArkJmPdQKZUatJOcPW6asWisYRgltgA+bM=; b=T+CjMSgOsCsvykI4hwQMblazD+ZMcWlXazaOp/Qebnze3LbyeY7Lz0122qgpsXSP0B B/LFjYFoC/g88OT/b1A8JIXwaH9BsS3oQN89hh/2CTQoHhmsQF3BFqc1GuHfL6C3HScO SUlTNT704nqU1oAI5QbscY1yVSEHB+pibes9ueS92Ba8nZZHpIO3sOLhntbnvzLqzC/p SmqLixgD2PTmakG4hdMKZ7st+SonwClmXkcdZcFY1h+ejaz7KDURy6nCFJiTL9U9OXEi GmKWSZ5iJNIZtSiDQP6LgSnb/E/Jx6/ygJXErWMjiKdgv6S5enknUa9gqJBBq6LIEXVy KsVg== X-Gm-Message-State: AOAM533zgZG1KsrnC/dp303VGx3aqwjBDEhXLjB+8/6DseNaVYWw0F6+ TozY2uL2nO4IN8wz6GfaftSSOIPIPk6Rdj1EXeADrnli X-Google-Smtp-Source: ABdhPJxcGyP+rY6OJv8/guQBy29cEHbepRX/c2vT1PL3ijrS75hLlWsBEBXK+gtOF0Y7BZqR/JBiiuSjyM8cN6sKhhU= X-Received: by 2002:a92:7309:0:b0:2ca:8c9c:752d with SMTP id o9-20020a927309000000b002ca8c9c752dmr9144096ilc.151.1651692390336; Wed, 04 May 2022 12:26:30 -0700 (PDT) MIME-Version: 1.0 References: <20220502093625.GA23225@kernel.org> In-Reply-To: From: Miguel Ojeda Date: Wed, 4 May 2022 21:26:19 +0200 Message-ID: Subject: Re: [PATCH] kunit: take `kunit_assert` as `const` To: David Gow Cc: Daniel Latypov , Miguel Ojeda , Brendan Higgins , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, On Wed, May 4, 2022 at 4:05 PM David Gow wrote: > > I definitely agree here -- I can't recall any particular plan that > would require this to be non-const, and we can always change it back > if we really need to. That is good to know, thanks! Out-of-tree users can always be a surprise... :) > Very exciting! I assume that's the PR here: > https://github.com/Rust-for-Linux/linux/pull/757 Indeed! I hope you like it -- we are taking the documentation tests in Rust (which are a very lightweight way of writing examples which double as tests) and generating KUnit test cases on the fly. For the moment it is just for the `kernel` crate, but the idea is to generalize it for modules etc. By the way, since you saw the PR... do you know if KUnit relies (or will rely) on "stack-dumping" functions like `longjmp`? Cheers, Miguel