From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Rolf Eike Beer <eb@emlix.com>,
stable@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Linux 4.9.180 build fails with gcc 9 and 'cleanup_module' specifies less restrictive attribute than its target …
Date: Fri, 2 Aug 2019 13:00:30 +0200 [thread overview]
Message-ID: <CANiq72kcZZwp2MRVF5Ls+drXCzVbCfZ7wZ8Y+rU93oGohVAGsQ@mail.gmail.com> (raw)
In-Reply-To: <20190802103346.GA14255@kroah.com>
On Fri, Aug 2, 2019 at 12:33 PM Greg KH <greg@kroah.com> wrote:
>
> On Fri, Aug 02, 2019 at 12:19:33PM +0200, Miguel Ojeda wrote:
> > On Fri, Aug 2, 2019 at 10:17 AM Rolf Eike Beer <eb@emlix.com> wrote:
> > >
> > > Am Samstag, 8. Juni 2019, 14:00:34 CEST schrieb Miguel Ojeda:
> > > > On Thu, Jun 6, 2019 at 8:59 PM Greg KH <greg@kroah.com> wrote:
> > > > > "manually fixing it up" means "hacked it to pieces" to me, I have no
> > > > > idea what the end result really was :)
> > > > >
> > > > > If someone wants to send me some patches I can actually apply, that
> > > > > would be best...
> > > >
> > > > I will give it a go whenever I get some free time :)
> > >
> > > I fear this has never happened, did it?
> >
> > No. Between summer, holidays and a conference I didn't get to do it.
> >
> > Done the minimal approach here:
> >
> > https://github.com/ojeda/linux/commits/compiler-attributes-backport
> >
> > Tested building a handful of drivers with gcc 4.6.4, 8.3.0 and 9.1.1.
> >
> > Greg, I could backport the entire compiler_attributes.h, but given
> > this is stable, we are supposed to minimize changes, right?
> >
> > I tried to imitate what you do in other stable patches, please check
> > the Cc:, Link: lines and the "commit ... upstream" just in case.
>
> If only those 2 patches are all that is needed, nice! I'll gladly take
> them, can you send them to me (and cc: the stable list) in email so I
> can queue them up for the next round of releases after this one?
At least for that particular problem, yeah -- I haven't done a full allmod.
By the way, I just checked 4.14.y and I noticed you had already
backported it, although going for another solution:
+#if GCC_VERSION >= 90100
+#define __copy(symbol) __attribute__((__copy__(symbol)))
+#endif
and then:
+#ifndef __copy
+# define __copy(symbol)
+#endif
Cheers,
Miguel
next prev parent reply other threads:[~2019-08-02 11:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 13:16 Linux 4.9.180 build fails with gcc 9 and 'cleanup_module' specifies less restrictive attribute than its target … Rolf Eike Beer
2019-06-06 15:27 ` Greg KH
2019-06-06 15:29 ` Greg KH
2019-06-06 18:25 ` Miguel Ojeda
2019-06-06 18:59 ` Greg KH
2019-06-08 12:00 ` Miguel Ojeda
2019-08-02 8:17 ` Rolf Eike Beer
2019-08-02 8:28 ` Greg KH
2019-08-02 10:19 ` Miguel Ojeda
2019-08-02 10:33 ` Greg KH
2019-08-02 10:39 ` Miguel Ojeda
2019-08-02 11:26 ` Greg KH
2019-08-02 11:00 ` Miguel Ojeda [this message]
2019-08-02 11:25 ` Greg KH
2019-08-02 13:01 ` Miguel Ojeda
2019-08-02 15:56 ` Greg KH
2019-08-02 16:55 ` Miguel Ojeda
2019-08-05 11:55 ` Greg KH
2019-08-05 12:47 ` Miguel Ojeda
2019-06-12 7:19 ` Rolf Eike Beer
2019-06-12 7:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72kcZZwp2MRVF5Ls+drXCzVbCfZ7wZ8Y+rU93oGohVAGsQ@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=eb@emlix.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).