From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C1E9C47404 for ; Fri, 11 Oct 2019 22:26:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2BAB218AC for ; Fri, 11 Oct 2019 22:26:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nqUsqy5Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729451AbfJKW0V (ORCPT ); Fri, 11 Oct 2019 18:26:21 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:46193 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729428AbfJKW0U (ORCPT ); Fri, 11 Oct 2019 18:26:20 -0400 Received: by mail-lj1-f195.google.com with SMTP id d1so11217025ljl.13; Fri, 11 Oct 2019 15:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xmHIYl25n4y/hTcfXXSO/nQ5G/kQTh9kEzA1dV2zubk=; b=nqUsqy5Zv5ik/Zj2UcjOrzceCGDWgwxpQFiWSlsq61+ZupecTO4hNZvtjqbCdkPgXx jSscEdEO8jLI/1BG2ec4/rPD2vaD3O0sK8zKqbadz4Jt/TNgYUWaPWdyrUIiDJLAKQhE 4leI/c1m4aOHU8lFwbAMt99/CgnanpbBC/MrdEkph6cXR0KO9E/tKzCbKJT5G2CFFU1g 2nQpP19/6JzY/IlC4YDP6UUo+HTUc/ecjKqST1CBxpj5MCHimyq/ijA2lQp/YKl07LKP lT3UvJtw1DRs4yNs3aiDG8jLvFmKGKtn5nE4G8N1qecE4wXrgcIv4Nj6Ub4vCWOGhJhT 0sNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xmHIYl25n4y/hTcfXXSO/nQ5G/kQTh9kEzA1dV2zubk=; b=Nve2vuNwtvsCAXRVRSTuYfyM2Elvu14W/t+K+ssDdfHQFdPmqaoNiwwNuvBVdhvedB o25cUpRTWcoXQvLMIDZQlWz2GpDOtuslJCGtvq05vnoEJs+QFqcOvPtCqKdeGGo8WnD9 8Z+8VOq87zHcl0BAACBMgrfyBpJKvKTIkgb1STE6+CsoSrgY3aj3JPXSP05B3wyNUcRn 7m/YMnREkVCm8QK1BrL7sXcB0rIpBHWN+7UWflZlUDr4uyXCq6QYG9G+yw4edDhpZYcI BYop76JrbhyOtU0fESO18NGchKaZlOdRPjUPD6jN9rK1x/J1iyXQUynmX8FjC32xVHCt rwoA== X-Gm-Message-State: APjAAAV9L/VdPjX9KeMpO1+qITUrVbp+TpsGaunKSuN5QLfcmvNNjSsD K1oaJgxA84csvUQDRy9telQ5uUMF8IQXONTOybQ= X-Google-Smtp-Source: APXvYqzhY4BBpDOb1XjrGtrPCztOkL7/vfw1DL4ZNsREHKyaPUxwViQwxlLovrTqj8EB0FcekvYwixhBodl7HEwIJ/c= X-Received: by 2002:a2e:8852:: with SMTP id z18mr10688944ljj.230.1570832777820; Fri, 11 Oct 2019 15:26:17 -0700 (PDT) MIME-Version: 1.0 References: <201910111506.45AE850D5@keescook> In-Reply-To: <201910111506.45AE850D5@keescook> From: Miguel Ojeda Date: Sat, 12 Oct 2019 00:26:06 +0200 Message-ID: Subject: Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword To: Kees Cook Cc: Linus Torvalds , Joe Perches , linux-sctp@vger.kernel.org, Borislav Petkov , "H . Peter Anvin" , Thomas Gleixner , Pavel Machek , "Gustavo A . R . Silva" , Arnaldo Carvalho de Melo , Kan Liang , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Shawn Landden , "the arch/x86 maintainers" , Linux Kernel Mailing List , Nathan Chancellor , Nick Desaulniers , Andrew Morton , David Miller , clang-built-linux , Jonathan Corbet , Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , "open list:DOCUMENTATION" , Netdev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 12, 2019 at 12:08 AM Kees Cook wrote: > > On Fri, Oct 11, 2019 at 08:01:42PM +0200, Miguel Ojeda wrote: > > Hi Linus, > > > > On Fri, Oct 11, 2019 at 6:30 PM Linus Torvalds > > wrote: > > > > > > On Sat, Oct 5, 2019 at 9:46 AM Joe Perches wrote: > > > > > > > > Add 'fallthrough' pseudo-keyword to enable the removal of comments > > > > like '/* fallthrough */'. > > > > > > I applied patches 1-3 to my tree just to make it easier for people to > > > start doing this. Maybe some people want to do the conversion on their > > > own subsystem rather than with a global script, but even if not, this > > > looks better as a "prepare for the future" series and I feel that if > > > we're doing the "fallthrough" thing eventually, the sooner we do the > > > prepwork the better. > > > > > > I'm a tiny bit worried that the actual conversion is just going to > > > cause lots of pain for the stable people, but I'll not worry about it > > > _too_ much. If the stable people decide that it's too painful for them > > > to deal with the comment vs keyword model, they may want to backport > > > these three patches too. > > > > I was waiting for a v2 series to pick it up given we had some pending changes... > > Hmpf, looks like it's in torvalds/master now. Miguel, most of the changes > were related to the commit log, IIRC, so that ship has sailed. :( Can the > stuff in Documentation/ be improved with a follow-up patch, perhaps? Linus seems to have applied some of the improvements to the commit messages, but not those to the content (not sure why, since they were also easy ones). But no worries, we will do those later :) Cheers, Miguel