From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E0DCC3A589 for ; Thu, 15 Aug 2019 23:54:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB5612064B for ; Thu, 15 Aug 2019 23:54:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H/e1PI8t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbfHOXyN (ORCPT ); Thu, 15 Aug 2019 19:54:13 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:45378 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726504AbfHOXyN (ORCPT ); Thu, 15 Aug 2019 19:54:13 -0400 Received: by mail-lf1-f66.google.com with SMTP id a30so2804399lfk.12; Thu, 15 Aug 2019 16:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uUR8sKJAysqvgde7a/GEolWZUsjVUl8S+CBNn4ZSzd0=; b=H/e1PI8tnfZHbSVcmTI3ZlTz/NDKqEbLupqbUDm6SFLMikorKxQDrI8jM2bw5Cj7Wc TkYmvKSsRqQP2MCg8Dy7LCRf/YOmveTd+sT2G7ZSy1J6gVDwdjfM4X9bZ4M5BqdF4tyR fX9+0BehG9+13N6ZvdPeFLilu7xbfpNB6vQNCFsc0+qNDDTu0rPjUPmvKcKhRcoGStno tUWQigjrXp/5PKkO6sOwRv8TMTGG3Qq3gBU8T5y/4hHl/2zuhwB3SjhIKBQMGl04GTeJ kSfiG+khAqeTuWG+3Yie+lr8E8HdE5ZhSb/+gRCBl019IGJF5r+SLn1JB+ta7wGJxeGb AvFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uUR8sKJAysqvgde7a/GEolWZUsjVUl8S+CBNn4ZSzd0=; b=YwmDYKjBPUlYyHXTDgWJ6Ll4es+Uc8BHOdzzDdq9EBbr18bbTl22q6iOHj/0xBn5ZK TKQM4ybqUMpu5Wshoyru8bANN8anHyYt88MZDCobGDn+zsqgE4uGoNsOX8r2ssbMCb63 gyWb8NdCC65M1I51/Gl2yPjqODsovwDpsMjbXcLHD4f6RX8VCfSbFg1x6bscC3CmFPAR p9rPSt2RXY+Xl6MtNJcvhOISPw6An+MDkRQYSI8jRGBzq8xInQ4uGlBe5r3qWBE0j8AS Z+9uTIhpXZnzImgy3CIboxjii/TLxnLxffIXi9dsaWy89oobEU66nXDaQelBiQuC67oi JfKg== X-Gm-Message-State: APjAAAWQCFPSYTwO0QG91Fm2Xqj5FPT4ZxjckJznBfEtWtP/1X5S3A0W xZCoyJfEghGmZNjv2HyqkFBActAQ3axHJwzfEWc= X-Google-Smtp-Source: APXvYqw9iMwlbGaYa9Gw4S54tbPxw0qnWHs1sXgDrojU1m0SkxO8PL1a615sX1xDGMc4IE0k1fF376dS8B7zOgup64A= X-Received: by 2002:ac2:4157:: with SMTP id c23mr3561969lfi.173.1565913251168; Thu, 15 Aug 2019 16:54:11 -0700 (PDT) MIME-Version: 1.0 References: <20190815182029.197604-1-nhuck@google.com> <20190815204529.GA69414@archlinux-threadripper> In-Reply-To: From: Miguel Ojeda Date: Fri, 16 Aug 2019 01:53:59 +0200 Message-ID: Subject: Re: [PATCH] kbuild: Require W=1 for -Wimplicit-fallthrough with clang To: Nick Desaulniers Cc: Nathan Chancellor , Nathan Huckleberry , Masahiro Yamada , Michal Marek , Joe Perches , Linux Kbuild mailing list , linux-kernel , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 16, 2019 at 1:05 AM Nick Desaulniers wrote: > > On Thu, Aug 15, 2019 at 3:59 PM Miguel Ojeda > wrote: > > > > On Thu, Aug 15, 2019 at 10:45 PM Nathan Chancellor > > wrote: > > > * Revert commit bfd77145f35c ("Makefile: Convert -Wimplicit-fallthrough=3 > > > to just -Wimplicit-fallthrough for clang") for the time being and just > > > rely on adding -Wimplicit-fallthrough to KCFLAGS for testing. > > > > I would avoid applying commits that will have to be reverted just for > > Clang, particularly since it is not fully supported yet. > > "not fully supported yet" you say? *drops monocle* > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/MAINTAINERS?h=v5.3-rc4#n4001 By fully supported I mean it already works and people can rely on it out of the box using a released version of Clang/LLVM. Is that the case already? If so, many places need updating! * include/linux/compiler-clang.h should check for the minimum supported version * Documentation/process/programming-language.rst should be updated * https://github.com/ClangBuiltLinux/linux/wiki does not mention anything etc. Cheers, Miguel