From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 4/4] auxdisplay: lcd2s: Use array size explicitly in lcd2s_gotoxy()
Date: Sat, 19 Mar 2022 01:29:23 +0100 [thread overview]
Message-ID: <CANiq72mVnHWi-tZmT4g+2Y96eYu=Hm=oMKn6RkwpXWh7ARATAA@mail.gmail.com> (raw)
In-Reply-To: <20220308151119.48412-4-andriy.shevchenko@linux.intel.com>
Hi Andy,
On Tue, Mar 8, 2022 at 4:11 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Currently the reading of the onstack array is confusing since two
> out of three members are of different types. Let it be more clear
> by explicitly set the array size, so everybody will understand that
> parameters are cast to the type of the array.
I am not sure what you mean by this, could you please elaborate why is
it more clear if the size is given?
Cheers,
Miguel
next prev parent reply other threads:[~2022-03-19 0:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 15:11 [PATCH v1 1/4] auxdisplay: lcd2s: make use of device property API Andy Shevchenko
2022-03-08 15:11 ` [PATCH v1 2/4] auxdisplay: lcd2s: use module_i2c_driver to simplify the code Andy Shevchenko
2022-03-08 15:11 ` [PATCH v1 3/4] auxdisplay: lcd2s: Switch to i2c ->probe_new() Andy Shevchenko
2022-03-08 15:11 ` [PATCH v1 4/4] auxdisplay: lcd2s: Use array size explicitly in lcd2s_gotoxy() Andy Shevchenko
2022-03-19 0:29 ` Miguel Ojeda [this message]
2022-03-19 11:37 ` Andy Shevchenko
2022-03-23 19:15 ` Miguel Ojeda
2022-03-24 9:21 ` Andy Shevchenko
2022-03-23 19:02 ` [PATCH v1 1/4] auxdisplay: lcd2s: make use of device property API Miguel Ojeda
2022-03-24 9:21 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72mVnHWi-tZmT4g+2Y96eYu=Hm=oMKn6RkwpXWh7ARATAA@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).