From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Adrian Fiergolski <adrian.fiergolski@cern.ch>
Cc: linux-spi@vger.kernel.org, broonie@kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add possibility to define bits-per-word property.
Date: Fri, 17 Feb 2017 11:06:44 +0100 [thread overview]
Message-ID: <CANiq72n2+osAdJfRiQwaWuqz2rM0EinhMzqnbDuiRNwFXBuzEg@mail.gmail.com> (raw)
In-Reply-To: <20170216133910.18278-1-adrian.fiergolski@cern.ch>
Hi Adrian,
Please review the style to match the kernel's (and the rest of the
code in the file). See an example below and
https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst
(I have no idea regarding the functional changes on this patch, I just
noticed the email coming from CERN and therefore I replied :-)
Cheers,
Miguel
On Thu, Feb 16, 2017 at 2:39 PM, Adrian Fiergolski
<adrian.fiergolski@cern.ch> wrote:
>
> Signed-off-by: Adrian Fiergolski <adrian.fiergolski@cern.ch>
> ---
> drivers/spi/spi.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index 0239b45..d2267e9 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -1549,6 +1549,17 @@ of_register_spi_device(struct spi_master *master, struct device_node *nc)
> }
> spi->max_speed_hz = value;
>
> + /* Device bits-per-word */
> + if( ! of_property_read_u32(nc, "spi-bits-per-word", &value) ){
e.g.
if (!of_property_read_u32(nc, "spi-bits-per-word", &value)) {
>
> + if( value > 32 )
> + dev_warn(&master->dev,
> + "bits-per-word %d not supported\n",
> + value);
> + else
> + spi->bits_per_word = value;
> + }
> +
> +
> /* Store a pointer to the node in the device structure */
> of_node_get(nc);
> spi->dev.of_node = nc;
> @@ -1626,6 +1637,13 @@ static int acpi_spi_add_resource(struct acpi_resource *ares, void *data)
>
> spi->max_speed_hz = sb->connection_speed;
>
> + if(sb->data_bit_length > 32)
> + dev_warn(&master->dev,
> + "bits-per-word %d not supported\n",
> + sb->data_bit_length);
> + else
> + spi->bits_per_word = sb->data_bit_length;
> +
> if (sb->clock_phase == ACPI_SPI_SECOND_PHASE)
> spi->mode |= SPI_CPHA;
> if (sb->clock_polarity == ACPI_SPI_START_HIGH)
> --
> 2.9.3
>
next prev parent reply other threads:[~2017-02-17 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 13:39 [PATCH] Add possibility to define bits-per-word property Adrian Fiergolski
2017-02-17 10:06 ` Miguel Ojeda [this message]
2017-02-17 10:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72n2+osAdJfRiQwaWuqz2rM0EinhMzqnbDuiRNwFXBuzEg@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=adrian.fiergolski@cern.ch \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).