From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Joe Perches <joe@perches.com>,
Michal Marek <michal.lkml@markovi.net>,
Nathan Chancellor <natechancellor@gmail.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] Kbuild: enable -Wfallthrough for clang
Date: Sat, 7 Nov 2020 12:17:47 +0100 [thread overview]
Message-ID: <CANiq72nR89xB_J3YVu8zC2MOTzVCDb26r+KofkNLWhYG=in6Uw@mail.gmail.com> (raw)
In-Reply-To: <20201107070744.1133811-1-ndesaulniers@google.com>
On Sat, Nov 7, 2020 at 8:08 AM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> Partial revert of commit e2079e93f562 ("kbuild: Do not enable
> -Wimplicit-fallthrough for clang for now")
Wait, it says partial revert because it is one, but doing it this way
does not enable the option back for GCC (and Clang).
Shouldn't it be a full revert?
Cheers,
Miguel
prev parent reply other threads:[~2020-11-07 11:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 7:07 [PATCH] Kbuild: enable -Wfallthrough for clang Nick Desaulniers
2020-11-07 8:07 ` Miguel Ojeda
2020-11-07 8:45 ` [PATCH v2] Revert "kbuild: Do not enable -Wimplicit-fallthrough for clang for now" Nick Desaulniers
2020-11-07 9:04 ` Nick Desaulniers
2020-11-09 9:33 ` kernel test robot
2020-11-09 10:42 ` kernel test robot
2020-11-07 11:17 ` Miguel Ojeda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72nR89xB_J3YVu8zC2MOTzVCDb26r+KofkNLWhYG=in6Uw@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gustavoars@kernel.org \
--cc=joe@perches.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).