From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BDFCC2BB41 for ; Wed, 17 Aug 2022 20:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242078AbiHQUkw (ORCPT ); Wed, 17 Aug 2022 16:40:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238164AbiHQUku (ORCPT ); Wed, 17 Aug 2022 16:40:50 -0400 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32D0A9BB71; Wed, 17 Aug 2022 13:40:50 -0700 (PDT) Received: by mail-il1-x12f.google.com with SMTP id z8so7506169ile.0; Wed, 17 Aug 2022 13:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=D7+PP+1VFVB5t/XZKXqn6MijouyQ2RbiiwpNQ7fWOz0=; b=GxR10IqzvjdBL/BaxMHXfPFWlt/83Q820CnMlzfL/hSA6gIjg68H5JxBTAxm/lIQ9V 0i7QhTrDa78ijLCS/8IiS1qk+BXnh1u3ZfTWADKknLCpzJTkMTnshCMrM8bbU6lICwwb RCQuKPTUOu0D8Cgy371UL8SU/k/ojDGxNm5xleYWISXyMRA0ftmiHl/vFGUl4fMwVUiE z1H1UPyZeJQ9Tlv2v8NclqCye8Gg2GUrr30eChzEFN/qUfvS5j+sg9zCz0e1pgLG8XrE +2vNeyK8ULLM29Av+5YMtJVAXSvHFvwfYwHRC1ylSLIReEpCYtUq4ABsIR3S2vaqOt6g 34cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=D7+PP+1VFVB5t/XZKXqn6MijouyQ2RbiiwpNQ7fWOz0=; b=QNmyB2nZrX4fH0RaFdlgQCuP4te7dJmHbTG60Uf3nUMMfZ1OwVSGAw+jUTlk31qQSv GgtooEoQVhxp72wKX0PdjJCbdoWkwpWbu8r5XitvyMKMyr+M7uaakNG2n9QYYIDmBCkK ZTHq396cOAZBPFJTZGrBnWAAKVbrt3BnlozzhpEwn25dAiomJmL01qx0IRnRosO4WzgK 8QbUgCH9wmpXumkBNDCndIsY5ucle5My9KdwRlslYxiQgy6CiSeXgk9cVv6d1/2c3IAj zNGEz5lA5xG0WHjmvBHGyO0PJUcy2RZuVSRUXjjsf98i68f1+dReLE5iD2EBJSWL7ooI uluw== X-Gm-Message-State: ACgBeo0qlgrCm48oYlV/yBUD3Sqrg9ysYrlX/Ut6i0VKz9RiKD+TMhpJ JG4o/CHWrZNvwIau8PELcpeCXk5oJkjrh/KVCaxBGffsB6KOscbp X-Google-Smtp-Source: AA6agR6Pkl8a8I0NGhaSmqIm0OjcWxsxxYn1fA+Kt0gIAQtc7Bo4Uukr+9wWczkLepZwrG+Tt2qdF9cNf7ysNCWyoII= X-Received: by 2002:a92:cd8f:0:b0:2df:ff82:2e5f with SMTP id r15-20020a92cd8f000000b002dfff822e5fmr12835073ilb.72.1660768849569; Wed, 17 Aug 2022 13:40:49 -0700 (PDT) MIME-Version: 1.0 References: <20220805154231.31257-1-ojeda@kernel.org> <20220805154231.31257-21-ojeda@kernel.org> <202208171317.F5D57135@keescook> In-Reply-To: <202208171317.F5D57135@keescook> From: Miguel Ojeda Date: Wed, 17 Aug 2022 22:40:38 +0200 Message-ID: Subject: Re: [PATCH v9 20/27] scripts: add `rust_is_available.sh` To: Kees Cook Cc: Miguel Ojeda , Linus Torvalds , Greg Kroah-Hartman , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, patches@lists.linux.dev, Jarkko Sakkinen , Alex Gaynor , Wedson Almeida Filho , Finn Behrens , Miguel Cano , Tiago Lam , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2022 at 10:18 PM Kees Cook wrote: > > I think the min-tool-version.sh changes from patch 23 should be moved > into this patch. Yeah, it calls into that script with a "rustc" argument, which doesn't work if somebody happened to run it by hand, so this makes sense. However, the intention was to move each "big" new file into their own patch to make a smaller Kbuild one (and only do that "new file" additions in each patch), and then finally do all the modifications and enable the Rust support in the Kbuild patch (which has the callers into this script). Also the script is not intended to be called directly anyway (since you need the Make environment, but you definitely can), there is a Make target to help with that. Hopefully that explains the logic behind the arrangement of the patches, which was to make the patches as simple as possible. I am happy to rearrange if you think it is more understandable that way. Cheers, Miguel