From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B45AC04AB1 for ; Thu, 9 May 2019 14:41:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BF5821479 for ; Thu, 9 May 2019 14:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557412918; bh=Wfj1GabWdVoULFKoG6CT8frw0TykxTd53AcRNApM0TU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=KHmiFzf3Jp7JN8LfOVADqi3KOW3WRhlSBMdNsLGKUq7IDktukELlEwsfslI2am4mq f9tkln5ylcopJQWBoMiyoOcuqsaSYUMSv/8Lft3rhMe4nutmgAlDMhigfFtwBWa7Zm WCC3FgPJP8LNuVxagBm1nWtuosj1fc/WTx+2Tq0A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726882AbfEIOl5 (ORCPT ); Thu, 9 May 2019 10:41:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:59914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726234AbfEIOl4 (ORCPT ); Thu, 9 May 2019 10:41:56 -0400 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A030E2173B; Thu, 9 May 2019 14:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557412915; bh=Wfj1GabWdVoULFKoG6CT8frw0TykxTd53AcRNApM0TU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dSTpkE90aqWN5gHVRcjqIZnCD3GEq5VmiaK4NaEFcN0f+J9mtqEzqiGaBcyEpNAMh 50SmW9Q4RZiEUmPi+RvzMOKH/OOG1b0mQvyRJ3nnJq0XcVPgame5xJCYcb0RlCEyqw MZTy5HMRElfb3Fweomhs4nxRi051oGa/p6tZGVek= Received: by mail-ed1-f47.google.com with SMTP id f37so2227061edb.13; Thu, 09 May 2019 07:41:55 -0700 (PDT) X-Gm-Message-State: APjAAAWTudLnXQ0LLLjMS/X/oc2Cko7HJmR0u6a7uuydkV5ZQcVzFee3 IKHz7HzjE0dTesFVwwz8KlgYR7/YkhNI09MQ1w4= X-Google-Smtp-Source: APXvYqx1UQeeC0LITggJzVsAZ70ni/5qHB/4tt0KGr2SyrDc9s/pfLRRg2SVZ25V+mjZN/v1DknmtTiZ8MKTxBS1wRU= X-Received: by 2002:a50:fa90:: with SMTP id w16mr4447844edr.184.1557412914233; Thu, 09 May 2019 07:41:54 -0700 (PDT) MIME-Version: 1.0 References: <1556528151-17221-1-git-send-email-hao.wu@intel.com> <1556528151-17221-13-git-send-email-hao.wu@intel.com> In-Reply-To: <1556528151-17221-13-git-send-email-hao.wu@intel.com> From: Alan Tull Date: Thu, 9 May 2019 09:41:18 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 12/18] fpga: dfl: afu: add error reporting support. To: Wu Hao Cc: Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel , linux-api@vger.kernel.org, Xu Yilun Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 29, 2019 at 4:12 AM Wu Hao wrote: > > Error reporting is one important private feature, it reports error > detected on port and accelerated function unit (AFU). It introduces > several sysfs interfaces to allow userspace to check and clear > errors detected by hardware. > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao Acked-by: Alan Tull Thanks! Alan > --- > v2: add more error code description for error clear sysfs in doc. > return -EINVAL instead of -EBUSY when input error code doesn't > match in error clear sysfs. > --- > Documentation/ABI/testing/sysfs-platform-dfl-port | 39 ++++ > drivers/fpga/Makefile | 1 + > drivers/fpga/dfl-afu-error.c | 225 ++++++++++++++++++++++ > drivers/fpga/dfl-afu-main.c | 4 + > drivers/fpga/dfl-afu.h | 4 + > 5 files changed, 273 insertions(+) > create mode 100644 drivers/fpga/dfl-afu-error.c