From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753531AbdHQVck (ORCPT ); Thu, 17 Aug 2017 17:32:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:49160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753271AbdHQVci (ORCPT ); Thu, 17 Aug 2017 17:32:38 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83B9F2170E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=atull@kernel.org MIME-Version: 1.0 In-Reply-To: <1498441938-14046-10-git-send-email-hao.wu@intel.com> References: <1498441938-14046-1-git-send-email-hao.wu@intel.com> <1498441938-14046-10-git-send-email-hao.wu@intel.com> From: Alan Tull Date: Thu, 17 Aug 2017 16:31:56 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 09/22] fpga: intel: pcie: adds fpga_for_each_port callback for fme device To: Wu Hao Cc: Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel , linux-api@vger.kernel.org, "Kang, Luwei" , "Zhang, Yi Z" , Tim Whisonant , Enno Luebbers , Shiva Rao , Christopher Rauer , Xiao Guangrong Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote: Hi Hao, > For FPGA Management Engine (FME), it requires fpga_for_each_port callback > for actions on ports, so export this function from PCIe driver by adding > the callback to the platform data. > > Signed-off-by: Tim Whisonant > Signed-off-by: Enno Luebbers > Signed-off-by: Shiva Rao > Signed-off-by: Christopher Rauer > Signed-off-by: Xiao Guangrong > Signed-off-by: Wu Hao > --- > v2: rebased > --- > drivers/fpga/intel-feature-dev.h | 9 +++++++++ > drivers/fpga/intel-pcie.c | 24 ++++++++++++++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/drivers/fpga/intel-feature-dev.h b/drivers/fpga/intel-feature-dev.h > index d64a51e..06b3fb6 100644 > --- a/drivers/fpga/intel-feature-dev.h > +++ b/drivers/fpga/intel-feature-dev.h > @@ -235,6 +235,9 @@ struct feature_platform_data { > struct platform_device *dev; > unsigned int disable_count; /* count for port disable */ > > + struct platform_device *(*fpga_for_each_port)(struct platform_device *, > + void *, int (*match)(struct platform_device *, void *)); > + > int num; /* number of features */ > struct feature features[0]; > }; > @@ -354,4 +357,10 @@ static inline int fpga_port_reset(struct platform_device *pdev) > > return pdata->features[index].ioaddr; > } > + > +static inline struct device * > +fpga_feature_dev_to_pcidev(struct platform_device *dev) > +{ > + return dev->dev.parent->parent; > +} > #endif > diff --git a/drivers/fpga/intel-pcie.c b/drivers/fpga/intel-pcie.c > index 54c0e3a..86ea5c7 100644 > --- a/drivers/fpga/intel-pcie.c > +++ b/drivers/fpga/intel-pcie.c > @@ -209,6 +209,27 @@ static int parse_switch_to(struct build_feature_devs_info *binfo, int bar) > return parse_start_from(binfo, bar); > } > > +static struct platform_device *fpga_for_each_port(struct platform_device *pdev, Regarding the name of this function, isn't this more of a 'find' function like class_find_device() than a 'for_each' function? Also please document that the caller will need to put_device(). Thanks, Alan > + void *data, int (*match)(struct platform_device *, void *)) > +{ > + struct device *pci_dev = fpga_feature_dev_to_pcidev(pdev); > + struct cci_drvdata *drvdata = dev_get_drvdata(pci_dev); > + struct feature_platform_data *pdata; > + struct platform_device *port_dev; > + > + mutex_lock(&drvdata->lock); > + list_for_each_entry(pdata, &drvdata->port_dev_list, node) { > + port_dev = pdata->dev; > + > + if (match(port_dev, data) && get_device(&port_dev->dev)) > + goto exit; > + } > + port_dev = NULL; > +exit: > + mutex_unlock(&drvdata->lock); > + return port_dev; > +} > + > static struct build_feature_devs_info * > build_info_alloc_and_init(struct pci_dev *pdev) > { > @@ -310,6 +331,9 @@ static int build_info_commit_dev(struct build_feature_devs_info *binfo) > if (!pdata) > return -ENOMEM; > > + if (type == FME_ID) > + pdata->fpga_for_each_port = fpga_for_each_port; > + > /* > * the count should be initialized to 0 to make sure > *__fpga_port_enable() following __fpga_port_disable() > -- > 1.8.3.1 >