From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754490AbdECOUe (ORCPT <rfc822;w@1wt.eu>);
        Wed, 3 May 2017 10:20:34 -0400
Received: from mail.kernel.org ([198.145.29.136]:48372 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753544AbdECOUY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 3 May 2017 10:20:24 -0400
MIME-Version: 1.0
In-Reply-To: <20170503021439.6d812223@crub>
References: <1493579317-28608-1-git-send-email-agust@denx.de>
 <CAHp75VdUc6TuB83SdCCWRSkc=r7iGk2k1AdOv8ytOS4GNXXPxg@mail.gmail.com>
 <20170502115308.1e2f1233@crub> <CAHp75VcQCa7pKSrTZDTH85G4ukY1QfmQG5epRjJDd8adufdK=w@mail.gmail.com>
 <20170503021439.6d812223@crub>
From: Alan Tull <atull@kernel.org>
Date: Wed, 3 May 2017 09:19:40 -0500
X-Gmail-Original-Message-ID: <CANk1AXRW2GUd+BbM6mSZwXtf9fNPus81QbV0YZWPtjpCGwtXyw@mail.gmail.com>
Message-ID: <CANk1AXRW2GUd+BbM6mSZwXtf9fNPus81QbV0YZWPtjpCGwtXyw@mail.gmail.com>
Subject: Re: [PATCH v4] fpga manager: Add Altera CvP driver
To: Anatolij Gustschin <agust@denx.de>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-fpga@vger.kernel.org, Alan Tull <atull@opensource.altera.com>,
        Moritz Fischer <moritz.fischer@ettus.com>,
        matthew.gerlach@linux.intel.com, "Li, Yi" <yi1.li@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 2, 2017 at 7:14 PM, Anatolij Gustschin <agust@denx.de> wrote:
> On Wed, 3 May 2017 00:28:17 +0300
> Andy Shevchenko andy.shevchenko@gmail.com wrote:
> ...
>>>>Is 0xff a mask here? (Btw, you missed spaces around <<)
>>>
>>> yes, it is. Will add spaces (checkpatch didn't warn here).
>>
>>Then it makes sense to add _MASK and use GENMASK() instead of direct value.
>
> ok, will do.
>
>>>>Why do we need that?!
>>>>In new drivers we try to avoid new module parameters. We have enough
>>>>interfaces nowadays to let driver know some details (quirks).
>>>
>>> Which interface is preffered here? Do you suggest sysfs? Won't be able
>>> to pass the parameter on kernel command line, then.
>>
>>Yes, my question here is to understand what so important that driver
>>needs module parameter.
>>Can you elaborate?
>
> the driver doesn't need this parameter, but it could help testing
> the loading of compressed or encrypted images.

Loading encrypted or compressed images can be keyed off of flags in
fpga_image_info.  Currently we have FPGA_MGR_ENCRYPTED_BITSTREAM  Will
need to add one for compressed such as FPGA_MGR_COMPRESSED_BITSTREAM

Alan