From: Alan Tull <atull@kernel.org>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: Alan Tull <atull@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fpga@vger.kernel.org
Subject: Re: [PATCH v2 10/16] fpga: region: use image info as parameter for programming region
Date: Tue, 9 May 2017 10:25:12 -0500 [thread overview]
Message-ID: <CANk1AXS02dKP6PbRevxvdBF8DvsT00EGQb5d-200VOwjbzBarg@mail.gmail.com> (raw)
In-Reply-To: <1492697401-11211-11-git-send-email-atull@kernel.org>
On Thu, Apr 20, 2017 at 9:09 AM, Alan Tull <atull@kernel.org> wrote:
> Use FPGA image info as a parameter when region code is
> programming the FPGA.
>
> This is a baby step in refactoring the FPGA region code to
> separate out common FPGA region code from FPGA region
> Device Tree overlay support.
>
> Signed-off-by: Alan Tull <atull@kernel.org>
> ---
> v2: split out from another patch
> ---
> drivers/fpga/fpga-region.c | 26 ++++++++++++++++----------
> include/linux/fpga/fpga-mgr.h | 4 ++++
> 2 files changed, 20 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
> index d6f2313..1892126 100644
> --- a/drivers/fpga/fpga-region.c
> +++ b/drivers/fpga/fpga-region.c
> @@ -223,16 +223,21 @@ static int fpga_region_get_bridges(struct fpga_region *region,
> /**
> * fpga_region_program_fpga - program FPGA
> * @region: FPGA region
> - * @overlay: device node of the overlay
> - * Program an FPGA using information in the region's fpga image info.
> + * @info: FPGA image info
> + * Program an FPGA using fpga image info.
> * Return 0 for success or negative error code.
> */
> static int fpga_region_program_fpga(struct fpga_region *region,
> - struct device_node *overlay)
> + struct fpga_image_info *info)
> {
> struct device *dev = ®ion->dev;
> int ret;
>
> + if (region->info) {
> + dev_err(dev, "region already programmed\n");
> + return PTR_ERR(region);
> + }
> +
Currently if region has info, that is supposed to mean that the region
is programmed. I can already see how that could be limiting. I'm
think that in v3, I'm going to change this to add a region->state or
region->status that can indicate whether the region has been
programmed. Having done that, the second parameter of this functon
can go away and region->info is used.
Alan
> region = fpga_region_get(region);
> if (IS_ERR(region)) {
> dev_err(dev, "failed to get FPGA region\n");
> @@ -245,7 +250,7 @@ static int fpga_region_program_fpga(struct fpga_region *region,
> goto err_put_region;
> }
>
> - ret = fpga_region_get_bridges(region, overlay);
> + ret = fpga_region_get_bridges(region, info->overlay);
> if (ret) {
> dev_err(dev, "failed to get FPGA bridges\n");
> goto err_unlock_mgr;
> @@ -257,7 +262,7 @@ static int fpga_region_program_fpga(struct fpga_region *region,
> goto err_put_br;
> }
>
> - ret = fpga_mgr_load(region->mgr, region->info);
> + ret = fpga_mgr_load(region->mgr, info);
> if (ret) {
> dev_err(dev, "failed to load FPGA image\n");
> goto err_put_br;
> @@ -269,6 +274,8 @@ static int fpga_region_program_fpga(struct fpga_region *region,
> goto err_put_br;
> }
>
> + region->info = info;
> +
> fpga_mgr_unlock(region->mgr);
> fpga_region_put(region);
>
> @@ -373,6 +380,8 @@ static int fpga_region_notify_pre_apply(struct fpga_region *region,
> if (!info)
> return -ENOMEM;
>
> + info->overlay = nd->overlay;
> +
> /* Read FPGA region properties from the overlay */
> if (of_property_read_bool(nd->overlay, "partial-fpga-config"))
> info->flags |= FPGA_MGR_PARTIAL_RECONFIG;
> @@ -420,12 +429,9 @@ static int fpga_region_notify_pre_apply(struct fpga_region *region,
> return -EINVAL;
> }
>
> - region->info = info;
> - ret = fpga_region_program_fpga(region, nd->overlay);
> - if (ret) {
> + ret = fpga_region_program_fpga(region, info);
> + if (ret)
> fpga_image_info_free(®ion->dev, info);
> - region->info = NULL;
> - }
>
> return ret;
> }
> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
> index 4e14bdb..66d0e32 100644
> --- a/include/linux/fpga/fpga-mgr.h
> +++ b/include/linux/fpga/fpga-mgr.h
> @@ -84,6 +84,7 @@ enum fpga_mgr_states {
> * @sgt: scatter/gather table containing FPGA image
> * @buf: contiguous buffer containing FPGA image
> * @count: size of buf
> + * @overlay: Device Tree overlay
> */
> struct fpga_image_info {
> u32 flags;
> @@ -94,6 +95,9 @@ struct fpga_image_info {
> struct sg_table *sgt;
> const char *buf;
> size_t count;
> +#ifdef CONFIG_OF
> + struct device_node *overlay;
> +#endif
> };
>
> /**
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-05-09 15:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 14:09 [PATCH v2 00/16] Enable upper layers using FPGA region w/o device tree Alan Tull
2017-04-20 14:09 ` [PATCH v2 01/16] doc: fpga: update documents for the FPGA API Alan Tull
2017-04-20 14:09 ` [PATCH v2 02/16] fpga: bridge: support getting bridge from device Alan Tull
2017-05-03 11:58 ` Wu Hao
2017-05-03 20:07 ` Alan Tull
2017-05-04 9:20 ` Wu Hao
2017-05-04 21:31 ` Alan Tull
2017-05-08 8:44 ` Wu, Hao
2017-05-08 20:44 ` Alan Tull
2017-05-08 20:52 ` Moritz Fischer
2017-05-08 21:02 ` Alan Tull
2017-05-08 21:11 ` Moritz Fischer
2017-05-08 21:20 ` Alan Tull
2017-05-08 21:55 ` Moritz Fischer
2017-05-09 7:16 ` Wu Hao
2017-04-20 14:09 ` [PATCH v2 03/16] fpga: mgr: API change to replace fpga load functions with single function Alan Tull
2017-04-21 20:08 ` Alan Tull
2017-04-20 14:09 ` [PATCH v2 04/16] fpga: mgr: separate getting/locking FPGA manager Alan Tull
2017-04-20 14:09 ` [PATCH v2 05/16] fpga: region: use dev_err instead of pr_err Alan Tull
2017-04-20 14:09 ` [PATCH v2 06/16] fpga: region: remove unneeded of_node_get and put Alan Tull
2017-05-05 17:08 ` Moritz Fischer
2017-04-20 14:09 ` [PATCH v2 07/16] fpga: region: get mgr early on Alan Tull
2017-04-20 14:09 ` [PATCH v2 08/16] fpga: region: check for child regions before allocing image info Alan Tull
2017-05-05 20:59 ` Moritz Fischer
2017-05-08 21:03 ` Alan Tull
2017-04-20 14:09 ` [PATCH v2 09/16] fpga: region: fix slow warning with more than one overlay Alan Tull
2017-04-20 14:09 ` [PATCH v2 10/16] fpga: region: use image info as parameter for programming region Alan Tull
2017-05-09 15:25 ` Alan Tull [this message]
2017-04-20 14:09 ` [PATCH v2 11/16] fpga: region: separate out code that parses the overlay Alan Tull
2017-04-20 14:09 ` [PATCH v2 12/16] fpga: region: add fpga-region.h header Alan Tull
2017-04-20 14:09 ` [PATCH v2 13/16] fpga: region: rename some functions prior to moving Alan Tull
2017-04-20 14:09 ` [PATCH v2 14/16] fpga: region: add register/unregister functions Alan Tull
2017-04-20 14:10 ` [PATCH v2 15/16] fpga: region: add fpga_region_class_find Alan Tull
2017-05-03 15:44 ` Moritz Fischer
2017-05-03 20:08 ` Alan Tull
2017-04-20 14:10 ` [PATCH v2 16/16] fpga: region: move device tree support to of-fpga-region.c Alan Tull
2017-04-28 6:38 ` Wu Hao
2017-04-28 17:37 ` Alan Tull
2017-04-20 14:16 ` [PATCH v2 00/16] Enable upper layers using FPGA region w/o device tree Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANk1AXS02dKP6PbRevxvdBF8DvsT00EGQb5d-200VOwjbzBarg@mail.gmail.com \
--to=atull@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moritz.fischer@ettus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).