From: Alan Tull <atull@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Moritz Fischer <mdf@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Dinh Nguyen <dinguyen@kernel.org>,
Appana Durga Kedareswara Rao <appanad@xilinx.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fpga@vger.kernel.org,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Alan Tull <atull@opensource.altera.com>,
Matthew Gerlach <matthew.gerlach@linux.intel.com>
Subject: Re: [PATCH 2/2] fpga: add FPGA manager debugfs
Date: Thu, 16 Aug 2018 09:25:35 -0500 [thread overview]
Message-ID: <CANk1AXTOKKVdVDEkQ5d73F3nzgDDK9jgm2gRPpXbNM5A4aNS1w@mail.gmail.com> (raw)
In-Reply-To: <9043a69f-47d8-0ffe-ca15-77c9c73c085f@infradead.org>
On Wed, Aug 15, 2018 at 5:34 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
Hi Randy,
> On 08/15/2018 03:09 PM, Alan Tull wrote:
>> From: Alan Tull <atull@opensource.altera.com>
>>
>> Implement DebugFS for the FPGA Manager Framework for
>> debugging and developmental use.
>>
>> Enabled by CONFIG_FPGA_MGR_DEBUG_FS
>
> Hi Alan,
>
> for your v2 changes:
>
>> Each FPGA gets its own directory such as
>> <debugfs>/fpga_manager/fpga0 and three files:
>
> s/three/four/
Yes
>
>>
>> * [RW] flags = flags as defined in fpga-mgr.h
>> * [RW] firmware_name = write/read back name of FPGA image
>> firmware file to program
>> * [WO] image = write-only file for directly writing
>> fpga image w/o firmware layer
>> * [RW] config_complete_timeout_us = maximum for the FPGA to
>> go to the operating state after
>> programming
>>
>> The debugfs is implemented in a separate fpga_mgr_debugfs.c
>
> debugfs interface is
Yes
>
>> file, but the FPGA manager core is still built as one
>> module. Note the name change from fpga-mgr.ko to fpga_mgr.ko.
>>
>> Signed-off-by: Alan Tull <atull@kernel.org>
>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>> ---
>> drivers/fpga/Kconfig | 7 ++
>> drivers/fpga/Makefile | 4 +-
>> drivers/fpga/fpga-mgr-debugfs.c | 221 ++++++++++++++++++++++++++++++++++++++++
>> drivers/fpga/fpga-mgr-debugfs.h | 22 ++++
>> drivers/fpga/fpga-mgr.c | 8 ++
>> include/linux/fpga/fpga-mgr.h | 3 +
>> 6 files changed, 264 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/fpga/fpga-mgr-debugfs.c
>> create mode 100644 drivers/fpga/fpga-mgr-debugfs.h
>>
>> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
>> index 1ebcef4..600924d 100644
>> --- a/drivers/fpga/Kconfig
>> +++ b/drivers/fpga/Kconfig
>> @@ -9,6 +9,13 @@ menuconfig FPGA
>> kernel. The FPGA framework adds a FPGA manager class and FPGA
>> manager drivers.
>>
>> +config FPGA_MGR_DEBUG_FS
>> + bool "FPGA Manager DebugFS"
>> + depends on FPGA && DEBUG_FS
>> + help
>> + Say Y here if you want to expose a DebugFS interface for the
>> + FPGA Manager Framework.
>
> Use tab indentation for bool, depends, and help lines.
>
> Use tab +2 spaces for help text.
Yes, thanks for catching that. I'll fix these in v2.
Thanks for the review!
Alan
>
>> +
>> if FPGA
>>
>> config FPGA_MGR_SOCFPGA
>
> thanks,
> --
> ~Randy
next prev parent reply other threads:[~2018-08-16 14:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 22:09 [PATCH 1/2] fpga: doc: documentation for FPGA debugfs Alan Tull
2018-08-15 22:09 ` [PATCH 2/2] fpga: add FPGA manager debugfs Alan Tull
2018-08-15 22:34 ` Randy Dunlap
2018-08-16 14:25 ` Alan Tull [this message]
2018-08-16 18:59 ` Moritz Fischer
2018-08-16 20:04 ` Alan Tull
2018-08-16 21:21 ` Federico Vaga
2018-08-16 22:00 ` Moritz Fischer
2018-08-17 7:00 ` Federico Vaga
[not found] ` <CANk1AXTUYTEJgWneS1n2WwaqyOAmohYFFoXOU51XX6j02=q9xw@mail.gmail.com>
2018-08-17 14:54 ` Federico Vaga
2018-08-17 15:22 ` Moritz Fischer
2018-08-17 17:44 ` Federico Vaga
2019-03-19 10:28 ` Appana Durga Kedareswara Rao
2019-03-19 10:32 ` Appana Durga Kedareswara Rao
2018-08-15 22:22 ` [PATCH 1/2] fpga: doc: documentation for FPGA debugfs Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANk1AXTOKKVdVDEkQ5d73F3nzgDDK9jgm2gRPpXbNM5A4aNS1w@mail.gmail.com \
--to=atull@kernel.org \
--cc=appanad@xilinx.com \
--cc=atull@opensource.altera.com \
--cc=corbet@lwn.net \
--cc=dinguyen@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).