linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Tull <atull@kernel.org>
To: Moritz Fischer <mdf@kernel.org>
Cc: Wu Hao <hao.wu@intel.com>,
	linux-fpga@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] fpga: of-fpga-region: Use platform_set_drvdata
Date: Sun, 26 Aug 2018 16:20:39 -0500	[thread overview]
Message-ID: <CANk1AXTuVbJLmtv_+L3Dr2GyQ+2gTjJFGwrtFsh0rMu2RbYzkw@mail.gmail.com> (raw)
In-Reply-To: <20180824152513.8336-1-mdf@kernel.org>

On Fri, Aug 24, 2018 at 10:26 AM Moritz Fischer <mdf@kernel.org> wrote:

Hi Moritz,

Looks good.  Thanks for the patches!

>
> Use platform_set_drvdata rather than dev_set_drvdata
> to match the platform_get_drvdata in the _remove()
> function of the platform driver.
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>

> ---
>  drivers/fpga/of-fpga-region.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
> index 35fabb8083fb..8c6120e30930 100644
> --- a/drivers/fpga/of-fpga-region.c
> +++ b/drivers/fpga/of-fpga-region.c
> @@ -421,7 +421,7 @@ static int of_fpga_region_probe(struct platform_device *pdev)
>                 goto eprobe_free;
>
>         of_platform_populate(np, fpga_region_of_match, NULL, &region->dev);
> -       dev_set_drvdata(dev, region);
> +       platform_set_drvdata(pdev, region);
>
>         dev_info(dev, "FPGA Region probed\n");
>
> --
> 2.18.0
>

      parent reply	other threads:[~2018-08-26 21:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24 15:25 [PATCH 1/2] fpga: of-fpga-region: Use platform_set_drvdata Moritz Fischer
2018-08-24 15:25 ` [PATCH 2/2] fpga: dfl-fme-region: Use platform_get_drvdata() Moritz Fischer
2018-08-24 18:16   ` Wu Hao
2018-08-26 21:21   ` Alan Tull
2018-08-26 21:20 ` Alan Tull [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANk1AXTuVbJLmtv_+L3Dr2GyQ+2gTjJFGwrtFsh0rMu2RbYzkw@mail.gmail.com \
    --to=atull@kernel.org \
    --cc=hao.wu@intel.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).