From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A9CC4338F for ; Sat, 24 Jul 2021 15:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AF0660E90 for ; Sat, 24 Jul 2021 15:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230137AbhGXPFz (ORCPT ); Sat, 24 Jul 2021 11:05:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbhGXPFo (ORCPT ); Sat, 24 Jul 2021 11:05:44 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0892C061575; Sat, 24 Jul 2021 08:46:15 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id h2so7264550lfu.4; Sat, 24 Jul 2021 08:46:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Sffnf9T+HDaeklR+SXFRloM02OtNxtUSj/wfngSo6ps=; b=axSiGC6W9WCnQx3YXyXZJ1Qoy1I1rjTHPv9m0VNZsi48GVA+8oIkuGSP2KnCQcZsvw qZht948bYXEDAI03qizSGACxNipG4KkJgVAL290PXyKKKe4BCCtJY5mBbdzC1hA/d4mj M4NmDEF0bN+6uv5lP7+7BLucfQkmNJ68Lkz1+AAqo/81RWZs36lyFfzrj8kH224zBK2J p6PtkBFYCMoe8kR7gW6NVKdDzmjxEVT57XvK4ufnlwy/viKy/s1lRr+aJ2fUMbiqesHj kbJg4RIc094t6PKYXVxC8DwQbBPsrv335GmkbtQUqQB+4jxBImKt1PKW7s3AvSRfQUin vfDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sffnf9T+HDaeklR+SXFRloM02OtNxtUSj/wfngSo6ps=; b=S+CTwUPYh64ORlCSFiXRHi98UoSIisyfnEWGTv6fVSM330k7xjminsTn6yWS4kzWfo zbi0UVpf84w3ogmQb06KWPeWWv9FR2SeGLWjg2nDo0Ye2UTugJGcRuN0XQhnEN3gW3TU IFmZ5HeEybqJBUAvlknkIAiBG68cTbtB8pWDWJoHlSlZAo7QLHfc3dTRow81A7OShEYV 8nvt2LMn4Pvj+1pvIRKhV5ulweUNjJJn1DJou2JRoIoGP4RBfUZRt40rBp+0AbikZbvD XFWwp4qsbKbOHIe6OY1bP3PlI41GKT/m1Gsp1FXrVmTus/M4hMw+RHxYPMvOenlX/Myi lYMQ== X-Gm-Message-State: AOAM531YkrW5nX1+Zs0K5BFiG/9gbyh8idya0TvG3FJZwsyd05EA6/52 +iDqOYZd8DS8PJabSTOCH3+V3BWqLD6EEV9lmd8= X-Google-Smtp-Source: ABdhPJw6Opk+Xec3/M1Gz6JkYtTn4AePvHDFW8tyCf9VNFToRaAHZcdccNgIku0kGKz7QXT1CJf+Lkc86sWw97BKE1I= X-Received: by 2002:a19:c312:: with SMTP id t18mr6901214lff.354.1627141573558; Sat, 24 Jul 2021 08:46:13 -0700 (PDT) MIME-Version: 1.0 References: <20210722062155.32998-1-puranjay12@gmail.com> <20210722062155.32998-2-puranjay12@gmail.com> <20210723172902.00004151@Huawei.com> In-Reply-To: <20210723172902.00004151@Huawei.com> From: Puranjay Mohan Date: Sat, 24 Jul 2021 21:16:02 +0530 Message-ID: Subject: Re: [PATCH v2 1/2] dt-bindings: iio: accel: Add ADXL355 in trivial-devices To: Jonathan Cameron Cc: "Hennerich, Michael" , Alexandru Ardelean , Jonathan Cameron , devicetree , linux-iio , Linux Kernel Mailing List , Lars-Peter Clausen , "Bogdan, Dragos" , "Berghe, Darius" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 23, 2021 at 9:59 PM Jonathan Cameron wrote: > > On Thu, 22 Jul 2021 11:51:53 +0530 > Puranjay Mohan wrote: > > > Add ADXL355, a 3-Axis MEMS Accelerometer into trivial-devices.yaml. > > > > Signed-off-by: Puranjay Mohan > > Hi Puranjay, > > So, a binding should include (as well as we can) all hardware elements, > not just those currently supported by the driver. > > This particular device has two interrupts + a dataready signal which is > effectively another interrupt. It also has dual power supplies. > > That makes it a rather non-trivial device from the point of view of > bindings. Hence, please give it a file of it's own and also document > the interrupt and supply elements. > > Jonathan > I will add a separate file in the next version. thanks, Puranjay > > --- > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > > index 8341e9d23..0097d6e81 100644 > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > > @@ -41,6 +41,8 @@ properties: > > - adi,adp5589 > > # +/-1C TDM Extended Temp Range I.C > > - adi,adt7461 > > + # ADXL355:- 3-Axis Low noise MEMS Accelerometer. > > + - adi,adxl355 > > # +/-1C TDM Extended Temp Range I.C > > - adt7461 > > # AMS iAQ-Core VOC Sensor >