From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62C19C433ED for ; Wed, 7 Apr 2021 05:13:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29EFC613CC for ; Wed, 7 Apr 2021 05:13:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348618AbhDGFNl (ORCPT ); Wed, 7 Apr 2021 01:13:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229603AbhDGFNj (ORCPT ); Wed, 7 Apr 2021 01:13:39 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ED8BC06174A; Tue, 6 Apr 2021 22:13:30 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id y1so19096211ljm.10; Tue, 06 Apr 2021 22:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ODqZnnD2EEay1SllWXm37iJmFhlL6e0CZyIcJ3pNyrA=; b=X0GuxvoH74m6tfZhWB7OeOGuHlbs6pl4rkMgCIpO7YiEB1msDw75dbeMS2LFBdcMek s7zidhBzF527bef6+xItUmTBC3Ipee+Euc4ATumelPLYN1h661ZnnB6rb9YnS9VIdMKs CkVgOdQGRnoIbJbgksrUSg/to8IEXrDJhFJAlIgctrRPoX3mJtQGKaZm9OiSxdnk0aW1 4YgINIuu/bMEtKUsSilDcYD42Y83EkMzjZrKTOtqRTgDcC8kndRylNx8LZrLJWCzSVyP jO7bCHBw8gr09z2ABMGMckpO+DYkXFMR3OTk/4vkL7qixvl2E64hE7SKenXTO6ME4Vju WLRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ODqZnnD2EEay1SllWXm37iJmFhlL6e0CZyIcJ3pNyrA=; b=URucd4IYXH4Yv/p0dx8HhZkSmLhhOU9Wqj07s9RB4tv9cEIlgDDL+nDeSyxjx0ijKn aeusYTM/iesJSXA/8GneEMdnyIZa25OMfRwLB/o1r9pdCAJBlqq8kZpdgC8I9RdPimwn RQMOCGmmnjCsf+PevsxzaawBqac42hSTgzSKB1g1ocN8vGmbBNlbZ3Pt90J5skRH2jQV NYGGCfQ+S58LJf23mGweVv7bVcrJBqTVokpY+i9SjuQ1uJTmIBKLuyYmfpAEBnUL/83U JhBMXJKs8DD5WjPdR0NORqq01DfadvOlZjEza96jWvbp9v39eZxxsWoLMU1v6ikMXOyG XVvQ== X-Gm-Message-State: AOAM530vzuOUFpMOAT4rlSNWTphNztaEGJbPVAtd6KjectxgzlpeQKHT 96DUYVyY9ZM92mrvV2MCr+kQICK3hY2ZcHp9rk4= X-Google-Smtp-Source: ABdhPJxE9idQPq6DN473Lea7pF/dCU6/HVLho/BwkJv4DZAgkBE/XxvaQg+GZBJMmwbIYqHwODvtgnbHq3xwqrxKGUs= X-Received: by 2002:a2e:5c47:: with SMTP id q68mr1005136ljb.314.1617772408480; Tue, 06 Apr 2021 22:13:28 -0700 (PDT) MIME-Version: 1.0 References: <20210406182852.263605-1-puranjay12@gmail.com> <20210406182852.263605-3-puranjay12@gmail.com> <3d840334-2c26-5748-8370-54cef6262e02@metafoo.de> In-Reply-To: <3d840334-2c26-5748-8370-54cef6262e02@metafoo.de> From: Puranjay Mohan Date: Wed, 7 Apr 2021 10:43:15 +0530 Message-ID: Subject: Re: [PATCH v3 2/2] iio: temperature: add driver support for ti tmp117 To: Lars-Peter Clausen Cc: alexandru.ardelean@analog.com, Jonathan Cameron , devicetree@vger.kernel.org, knaack.h@gmx.de, linux-iio , Linux Kernel Mailing List , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 7, 2021 at 10:26 AM Lars-Peter Clausen wrote: > > On 4/6/21 8:28 PM, Puranjay Mohan wrote: > > + > > +static int tmp117_write_raw(struct iio_dev *indio_dev, > > + struct iio_chan_spec const *channel, int val, > > + int val2, long mask) > > +{ > > + struct tmp117_data *data = iio_priv(indio_dev); > > + s16 off; > > + > > + switch (mask) { > > + case IIO_CHAN_INFO_CALIBBIAS: > > + off = clamp(val, -32768, 32767); > > + if (off == data->calibbias) > > data->calibbias is only set in probe() and always 0. I'm not sure we > need to cache the value. Reading it back from the device seems fine. I forgot to update it, thanks for finding the bug. Actually, I wanted to update the calibbias register only if a different value is being written. If the same value is written to the device repeatedly then we can save some I2C writes using this. and while reading the calibbias, it is read from the device only. I will fix the bug in the next revision. > > > + return 0; > > + return i2c_smbus_write_word_swapped(data->client, > > + TMP117_REG_TEMP_OFFSET, off); > > + > > + default: > > + return -EINVAL; > > + } > > +} > > + > -- Thanks and Regards Yours Truly, Puranjay Mohan