linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Puranjay Mohan <puranjay12@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org,
	jic23@kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 0/1] device property: Adding fwnode_irq_get_by_name()
Date: Wed, 10 Nov 2021 01:00:26 +0530	[thread overview]
Message-ID: <CANk7y0jsy9m3YLdSgjsoP-w_NcS-QZx3UTd+jnMHdRrhQ8zgeQ@mail.gmail.com> (raw)
In-Reply-To: <YYeOVJjiz6huHv4y@kroah.com>

On Sun, Nov 7, 2021 at 1:59 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sat, Nov 06, 2021 at 11:09:08PM +0530, Puranjay Mohan wrote:
> > While working on an IIO driver I was told to use of_irq_get_byname() as
> > the generic version is not available in property.c.
> > I wish to work on this and have written a function that may work.
> > I am not sure about its correctness so I am posting this patch early for
> > review.
>

Hi Greg,

> Please test your code, and also provide a user for it.  We can not take
> new functions that no one uses as that usually means they do not work.

Actually, I just wanted to get a review of this code before I test it.
Now, I have made a few changes and tested it using an IIO driver on a
raspberry pi and the sensor.
I will be posting a v2 that also includes a user of this function.

>
> thanks,
>
> greg k-h




Thanks,
Puranjay Mohan

  reply	other threads:[~2021-11-09 19:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-06 17:39 [PATCH 0/1] device property: Adding fwnode_irq_get_by_name() Puranjay Mohan
2021-11-06 17:39 ` [PATCH 1/1] device property: Add fwnode_irq_get_by_name Puranjay Mohan
2021-11-07  1:33   ` kernel test robot
2021-11-07 12:37   ` kernel test robot
2021-11-07  8:29 ` [PATCH 0/1] device property: Adding fwnode_irq_get_by_name() Greg KH
2021-11-09 19:30   ` Puranjay Mohan [this message]
2021-11-09 19:45     ` Greg KH
2021-11-09 20:13       ` Puranjay Mohan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANk7y0jsy9m3YLdSgjsoP-w_NcS-QZx3UTd+jnMHdRrhQ8zgeQ@mail.gmail.com \
    --to=puranjay12@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).