From: Eric Dumazet <edumazet@google.com>
To: Zhongya Yan <yan2228598786@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Ingo Molnar <mingo@redhat.com>,
David Miller <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>, Yonghong Song <yhs@fb.com>,
2228598786@qq.com
Subject: Re: [PATCH] net: tcp_drop adds `reason` v5
Date: Mon, 13 Sep 2021 09:26:56 -0700 [thread overview]
Message-ID: <CANn89i+EvheAER7uHvacU0=DRsQoXkCi3P9_v0VXoTkZU7K2TA@mail.gmail.com> (raw)
In-Reply-To: <20210913130034.103362-1-yan2228598786@gmail.com>
On Mon, Sep 13, 2021 at 6:01 AM Zhongya Yan <yan2228598786@gmail.com> wrote:
>
> Description information in the reason field of tcp_drop, "Tcp" is changed to "TCP"
> Feel free to suggest changes
>
This is a cryptic changelog.
Have you forgotten to copy/paste important information ?
We would like something that explains what the patch is about, and
eventually how to use the new functionality.
Do not assume future readers of linux TCP stack will have instant
access to all your prior versions
Also patch is about tcp, net: prefix in patch title should be tcp:
Thanks.
prev parent reply other threads:[~2021-09-13 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 13:00 [PATCH] net: tcp_drop adds `reason` v5 Zhongya Yan
2021-09-13 16:26 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89i+EvheAER7uHvacU0=DRsQoXkCi3P9_v0VXoTkZU7K2TA@mail.gmail.com' \
--to=edumazet@google.com \
--cc=2228598786@qq.com \
--cc=brendan.d.gregg@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=yan2228598786@gmail.com \
--cc=yhs@fb.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).