From: Eric Dumazet <edumazet@google.com>
To: Mao Wenan <wenan.mao@linux.alibaba.com>
Cc: David Miller <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net v2] net: Update window_clamp if SOCK_RCVBUF is set
Date: Mon, 9 Nov 2020 12:02:27 +0100 [thread overview]
Message-ID: <CANn89i+oS75TVKBDOBrr7Ff55Uctq4_HUcM_05Ed8kUL1HkHLw@mail.gmail.com> (raw)
In-Reply-To: <3b92167c-201c-e85d-822d-06f0c9ac508c@linux.alibaba.com>
On Mon, Nov 9, 2020 at 11:12 AM Mao Wenan <wenan.mao@linux.alibaba.com> wrote:
>
>
>
> 在 2020/11/9 下午5:56, Eric Dumazet 写道:
> > On Mon, Nov 9, 2020 at 10:33 AM Mao Wenan <wenan.mao@linux.alibaba.com> wrote:
> >>
> >> When net.ipv4.tcp_syncookies=1 and syn flood is happened,
> >> cookie_v4_check or cookie_v6_check tries to redo what
> >> tcp_v4_send_synack or tcp_v6_send_synack did,
> >> rsk_window_clamp will be changed if SOCK_RCVBUF is set,
> >> which will make rcv_wscale is different, the client
> >> still operates with initial window scale and can overshot
> >> granted window, the client use the initial scale but local
> >> server use new scale to advertise window value, and session
> >> work abnormally.
> >
> > What is not working exactly ?
> >
> > Sending a 'big wscale' should not really matter, unless perhaps there
> > is a buggy stack at the remote end ?
> 1)in tcp_v4_send_synack, if SO_RCVBUF is set and
> tcp_full_space(sk)=65535, pass req->rsk_window_clamp=65535 to
> tcp_select_initial_window, rcv_wscale will be zero, and send to client,
> the client consider wscale is 0;
> 2)when ack is back from client, if there is no this patch,
> req->rsk_window_clamp is 0, and pass to tcp_select_initial_window,
> wscale will be 7, this new rcv_wscale is no way to advertise to client.
> 3)if server send rcv_wind to client with window=63, it consider the real
> window is 63*2^7=8064, but client consider the server window is only
> 63*2^0=63, it can't send big packet to server, and the send-q of client
> is full.
>
I see, please change your patches so that tcp_full_space() is used _once_
listener sk_rcvbuf can change under us.
I really have no idea how window can be set to 63, so please send us
the packetdrill test once you have it.
next prev parent reply other threads:[~2020-11-09 11:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 9:20 [PATCH] net: Update window_clamp if SOCK_RCVBUF is set Mao Wenan
2020-11-09 9:33 ` [PATCH net v2] " Mao Wenan
2020-11-09 9:56 ` Eric Dumazet
2020-11-09 10:12 ` Mao Wenan
2020-11-09 10:19 ` Mao Wenan
2020-11-09 11:02 ` Eric Dumazet [this message]
2020-11-09 11:41 ` Eric Dumazet
2020-11-09 14:01 ` Eric Dumazet
2020-11-09 16:26 ` Mao Wenan
2020-11-09 16:53 ` [PATCH net v3] " Mao Wenan
2020-11-09 16:59 ` Eric Dumazet
2020-11-09 17:17 ` [PATCH net v4] " Mao Wenan
2020-11-09 17:28 ` Eric Dumazet
2020-11-10 0:16 ` [PATCH net v5] " Mao Wenan
2020-11-10 7:32 ` Eric Dumazet
2020-11-11 1:45 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89i+oS75TVKBDOBrr7Ff55Uctq4_HUcM_05Ed8kUL1HkHLw@mail.gmail.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wenan.mao@linux.alibaba.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).