From: Eric Dumazet <edumazet@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Zhongya Yan <yan2228598786@gmail.com>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Ingo Molnar <mingo@redhat.com>,
David Miller <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
hengqi.chen@gmail.com, Yonghong Song <yhs@fb.com>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
2228598786@qq.com
Subject: Re: [PATCH] net: tcp_drop adds `reason` and SNMP parameters for tracing v4
Date: Tue, 7 Sep 2021 08:24:29 -0700 [thread overview]
Message-ID: <CANn89iJVc3kNU+4biyHRQtUQVYQpN5sPDTW5sfpyCo8uV-uSpg@mail.gmail.com> (raw)
In-Reply-To: <20210907111201.783d5ea2@gandalf.local.home>
On Tue, Sep 7, 2021 at 8:12 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> Just curious. Is "Tcp" the normal way to write "TCP" in the kernel? I see
> it in snmp_seq_show_tcp_udp() in net/ipv4/proc.c, but no where else
> (besides doing CamelCase words). Should these be written using "TCP"
> instead of "Tcp". It just looks awkward to me.
>
Yes, we prefer tcp or TCP, although SNMP counters have Tcp in them,
for some reason
( grep Tcp /proc/net/netstat /proc/net/snmp ), that can not be changed.
next prev parent reply other threads:[~2021-09-07 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 6:40 [PATCH] net: tcp_drop adds `reason` and SNMP parameters for tracing v4 Zhongya Yan
2021-09-04 19:04 ` Cong Wang
[not found] ` <CALcyL7h=vS_Nmg4GfRe-SD9ZSZopCM5p6U1mojn1gncw1Nds6g@mail.gmail.com>
2021-09-20 16:58 ` Cong Wang
2021-09-07 15:12 ` Steven Rostedt
2021-09-07 15:24 ` Eric Dumazet [this message]
2021-09-11 10:50 Zhongya Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iJVc3kNU+4biyHRQtUQVYQpN5sPDTW5sfpyCo8uV-uSpg@mail.gmail.com \
--to=edumazet@google.com \
--cc=2228598786@qq.com \
--cc=brendan.d.gregg@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=hengqi.chen@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=yan2228598786@gmail.com \
--cc=yhs@fb.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).