From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98372C4332F for ; Wed, 14 Dec 2022 15:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238764AbiLNPQL (ORCPT ); Wed, 14 Dec 2022 10:16:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238373AbiLNPQG (ORCPT ); Wed, 14 Dec 2022 10:16:06 -0500 Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B4F912D2C for ; Wed, 14 Dec 2022 07:16:02 -0800 (PST) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-40b40ff39f1so141697b3.10 for ; Wed, 14 Dec 2022 07:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i8/7ompYoprPv6p5gopqt1zlXtmepYGFLCWXe2gsqzg=; b=BUfL3YrZ28K+1n6E2SQ9fOqgRKi2RgeotU3ckXNn8xFWPTs42cuoGfphfjNQOV0pgx 7/jp35I3w0HRIOFVcsghYPgMBrhr8AMNN8/bTKnJa17Hz49AiqnR3KxJME/VVIigK+sS o/Lm4IOiEo8w6nxX4t2A4IzKZLODEjcrKKDsdmGKLI1atzrsu3mpNZREk5A83gxmOZAt L+k/IzYKvXs7B7hnKP1erYHIobJ4iQu87BD3pnHQtG8fBQOI4ExEQ0QtE/CElufFbNCA yV0c98uSdPhEqukbLuFuzz8L6ZLLU8J5/FlBKjiGFYDWzKiB3XFMXdMwK39OTfRDW0AO GSIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i8/7ompYoprPv6p5gopqt1zlXtmepYGFLCWXe2gsqzg=; b=KhRuQhtytpxJVOTeiKgtWVV3TG4IpZGvdorX7QXZK58vc/NBsjfZlpSadtpAJy2Ayp ErbQ0ur/mw7zssTOFwonKfm1eioxe1O+3bJtz7aW157vH/wlTOgE1O2IiOIeli+g66qB TmWQ0CEyALFiC0VjeWlBcXka+I0ckpMk/m/MriijUHRGYWI0jNw5aMjWKq4mNrgMq46T GZLwU/plAx8La2Yr8QU+BIyuCtEHxqMcl1UWYcXo75JlIpqWPiBrgNXiIttzOx/r1/HP Ls7fuUCiOiwA+pKCqxdt5mTN0jcCqr/VxoPvEqiAQNyZf4nLroHNv+VrjhBrTAdJDzhU D8Lg== X-Gm-Message-State: ANoB5pkKKmA5N/TaUgju9DceU70rWZNJvQo2j/7jP9e9L7rnuLugPlLg nBfsxxZI4nrDd4huHUml80lMehGkS/p8OL31vOgiqA== X-Google-Smtp-Source: AA0mqf6N7NofCRVaBdlZmzX/2IFdQaSJdENS2yaazN5Bc4VEowcispQ6llOh6euNJwrBHENhxHLAYZsrXmLpw9L8cy4= X-Received: by 2002:a81:1e44:0:b0:370:7a9a:564 with SMTP id e65-20020a811e44000000b003707a9a0564mr27785992ywe.278.1671030961275; Wed, 14 Dec 2022 07:16:01 -0800 (PST) MIME-Version: 1.0 References: <20221214123358.GA1062210@linux.intel.com> In-Reply-To: <20221214123358.GA1062210@linux.intel.com> From: Eric Dumazet Date: Wed, 14 Dec 2022 16:15:49 +0100 Message-ID: Subject: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state To: Stanislaw Gruszka Cc: "Jason A. Donenfeld" , david.keisarschm@mail.huji.ac.il, Vignesh Raghavendra , Peter Zijlstra , Dave Hansen , Rasmus Villemoes , Alexei Starovoitov , dri-devel@lists.freedesktop.org, Song Liu , linux-mtd@lists.infradead.org, Stanislav Fomichev , Miquel Raynal , Roman Gushchin , Christoph Lameter , "H. Peter Anvin" , Daniel Borkmann , Richard Weinberger , x86@kernel.org, John Fastabend , Andrii Nakryiko , ilay.bahat1@gmail.com, Ingo Molnar , Steven Rostedt , Jiri Pirko , David Rientjes , Yonghong Song , Paolo Abeni , intel-gfx@lists.freedesktop.org, Petr Mladek , Jiri Olsa , Hao Luo , "James E.J. Bottomley" , KP Singh , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jakub Kicinski , Borislav Petkov , Hannes Reinecke , Andy Lutomirski , Rodrigo Vivi , Thomas Gleixner , Andy Shevchenko , Andrew Morton , Vlastimil Babka , Tvrtko Ursulin , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Pekka Enberg , Sergey Senozhatsky , aksecurity@gmail.com, Joonsoo Kim , Martin KaFai Lau , "David S. Miller" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2022 at 1:34 PM Stanislaw Gruszka wrote: > > On Mon, Dec 12, 2022 at 03:35:20PM +0100, Jason A. Donenfeld wrote: > > Please CC me on future revisions. > > > > As of 6.2, the prandom namespace is *only* for predictable randomness. > > There's no need to rename anything. So nack on this patch 1/5. > > It is not obvious (for casual developers like me) that p in prandom > stands for predictable. Some renaming would be useful IMHO. Renaming makes backports more complicated, because stable teams will have to 'undo' name changes. Stable teams are already overwhelmed by the amount of backports, and silly merge conflicts. Take another example : u64 timecounter_read(struct timecounter *tc) You would think this function would read the timecounter, right ? Well, it _updates_ many fields from @tc, so a 'better name' would also be useful. linux kernel is not for casual readers.