From: Eric Dumazet <edumazet@google.com>
To: menglong8.dong@gmail.com
Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
dsahern@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Menglong Dong <imagedong@tencent.com>
Subject: Re: [PATCH net-next 3/3] net: tcp: handle window shrink properly
Date: Wed, 17 May 2023 16:47:38 +0200 [thread overview]
Message-ID: <CANn89iKLf=V664AsUYC52h_q-xjEq9xC3KqTq8q+t262T91qVQ@mail.gmail.com> (raw)
In-Reply-To: <20230517124201.441634-4-imagedong@tencent.com>
On Wed, May 17, 2023 at 2:42 PM <menglong8.dong@gmail.com> wrote:
>
> From: Menglong Dong <imagedong@tencent.com>
>
> Window shrink is not allowed and also not handled for now, but it's
> needed in some case.
>
> In the origin logic, 0 probe is triggered only when there is no any
> data in the retrans queue and the receive window can't hold the data
> of the 1th packet in the send queue.
>
> Now, let's change it and trigger the 0 probe in such cases:
>
> - if the retrans queue has data and the 1th packet in it is not within
> the receive window
> - no data in the retrans queue and the 1th packet in the send queue is
> out of the end of the receive window
Sorry, I do not understand.
Please provide packetdrill tests for new behavior like that.
Also, such fundamental change would need IETF discussion first.
We do not want linux to cause network collapses just because billions
of devices send more zero probes.
next prev parent reply other threads:[~2023-05-17 14:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 12:41 [PATCH net-next 0/3] net: tcp: add support of window shrink menglong8.dong
2023-05-17 12:41 ` [PATCH net-next 1/3] net: tcp: add sysctl for controling tcp " menglong8.dong
2023-05-17 12:42 ` [PATCH net-next 2/3] net: tcp: send zero-window when no memory menglong8.dong
2023-05-17 14:44 ` Eric Dumazet
2023-05-18 2:14 ` Menglong Dong
2023-05-18 14:25 ` Menglong Dong
2023-05-17 12:42 ` [PATCH net-next 3/3] net: tcp: handle window shrink properly menglong8.dong
2023-05-17 14:47 ` Eric Dumazet [this message]
2023-05-18 2:34 ` Menglong Dong
2023-05-18 13:40 ` Neal Cardwell
2023-05-18 14:11 ` Menglong Dong
2023-05-18 16:03 ` Neal Cardwell
2023-05-20 9:07 ` Menglong Dong
2023-05-20 14:28 ` Neal Cardwell
2023-05-22 2:55 ` Menglong Dong
2023-05-22 15:04 ` Neal Cardwell
2023-05-23 8:59 ` Menglong Dong
2023-05-23 13:27 ` Neal Cardwell
2023-05-24 12:16 ` Menglong Dong
2023-05-24 14:49 ` Neal Cardwell
2023-05-23 10:26 ` Eric Dumazet
2023-05-17 16:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iKLf=V664AsUYC52h_q-xjEq9xC3KqTq8q+t262T91qVQ@mail.gmail.com' \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=imagedong@tencent.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).