From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CCC9C0018C for ; Thu, 10 Dec 2020 14:54:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31FAF23108 for ; Thu, 10 Dec 2020 14:54:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729744AbgLJOye (ORCPT ); Thu, 10 Dec 2020 09:54:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733277AbgLJOyC (ORCPT ); Thu, 10 Dec 2020 09:54:02 -0500 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D03BCC0613D6 for ; Thu, 10 Dec 2020 06:53:21 -0800 (PST) Received: by mail-il1-x143.google.com with SMTP id v3so5558013ilo.5 for ; Thu, 10 Dec 2020 06:53:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yeZ8gIpFQsdSytGiB9IK+Ej4WbbINVDqeD0QoV2QEwU=; b=sGOYKdxnXRmFw5udWeVygXWbrL6g3yiJyReDFX9DIaEv628Z7gfbmlTa3kV3ns0RN8 Fm1hmLyYbAWmRyjVWy1rtzvy+vmE+/IoPOU8IUz2xIJ32sQpMaA30H1dd54Mm7Ol0gg8 6sSUPrSmgh7z+8FJdBa/K1wFx8EyO+GQm7RYE/KH7XMgatjcsoOh4+TAIZ4xALtUTYaH bz6lY8HFcaHavaP4r2F4f86sSAHml6Xod2/I4wsTr7vG44Xw43bNUwmtTET4hhN/QlhU uVav9FGOugP1h0qX4VYIsasf6cflBksuVHCvM7JSx3Ui7OMiuAb/eK73JOrd9L8gVkW3 Vogw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yeZ8gIpFQsdSytGiB9IK+Ej4WbbINVDqeD0QoV2QEwU=; b=INOOQ7zzQPb3NW22al3PL1jQe0DI7hwMNNDuzZcRZWMDmZBM09SEP3hGsmWMvIdybN cZ2Ik29s50U8CrClVDfU0B8CJBOJs/WVcCU8GC+Y/4NRDVW4coAHti632iXGjgAm5sAj 4mAVmJyINeI1lSSVRwHIULjr/a7YZZWSvsgygGS2HWKftK8JLgbLLTB53MRXMLUWIqXJ 3GZh44iLSGSrN7xa1qZJz/s703vxJ3lP4IzdYx1BfBpeVRPrBuGPqH4Axl7mxFSpoYek pPh0iAOBupL9wZcG0l5tnAnc2uiLWtTO+e1lKcLWtjAI9nqx5jP8xtAX+dSgguxbCIYO Q3qA== X-Gm-Message-State: AOAM53101qS+gSa0pcsfKk/tzotSzQDroxz5YpI7vUFIfAtjcqc5WtVx uMTwghZzzNGG9fl8+9184LqByi0SoDVhPm0p0moBvQ== X-Google-Smtp-Source: ABdhPJy5mH//MsFyk06EpBitTVKJlWGMGAVTvIaoL59lVVaI5t7OU/A4NxGApzRE+TNC3wIGYeMn8E98UVXCaEeO3bI= X-Received: by 2002:a92:da82:: with SMTP id u2mr9289009iln.137.1607612001021; Thu, 10 Dec 2020 06:53:21 -0800 (PST) MIME-Version: 1.0 References: <20201210142600.887734129@linuxfoundation.org> <20201210142601.652963609@linuxfoundation.org> In-Reply-To: From: Eric Dumazet Date: Thu, 10 Dec 2020 15:53:09 +0100 Message-ID: Subject: Re: [PATCH 4.4 15/39] geneve: pull IP header before ECN decapsulation To: Greg Kroah-Hartman Cc: LKML , stable@vger.kernel.org, syzbot , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2020 at 3:40 PM Greg Kroah-Hartman wrote: > > On Thu, Dec 10, 2020 at 03:38:44PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Dec 10, 2020 at 03:32:12PM +0100, Eric Dumazet wrote: > > > On Thu, Dec 10, 2020 at 3:26 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > From: Eric Dumazet > > > > > > > > IP_ECN_decapsulate() and IP6_ECN_decapsulate() assume > > > > IP header is already pulled. > > > > > > > > geneve does not ensure this yet. > > > > > > > > Fixing this generically in IP_ECN_decapsulate() and > > > > IP6_ECN_decapsulate() is not possible, since callers > > > > pass a pointer that might be freed by pskb_may_pull() > > > > > > > > syzbot reported : > > > > > > > > > > Note that we had to revert this patch, so you can either scratp this > > > backport, or make sure to backport the revert. > > > > I'll drop it thanks. Odd I lost the upstream git id on this patch, let > > me check what went wrong... > > What is the git id of the revert? This ended up already in 4.19.y, > 5.4.y, and 5.9.y so needs to be reverted there. > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=c02bd115b1d25931159f89c7d9bf47a30f5d4b41 Thanks ! > thanks, > > greg k-h