From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DCC3C433EF for ; Wed, 2 Mar 2022 01:23:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238868AbiCBBXu (ORCPT ); Tue, 1 Mar 2022 20:23:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238805AbiCBBXt (ORCPT ); Tue, 1 Mar 2022 20:23:49 -0500 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 040CE4B841 for ; Tue, 1 Mar 2022 17:23:07 -0800 (PST) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-2d07ae0b1bfso1064057b3.6 for ; Tue, 01 Mar 2022 17:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZafyWrCRm6FANBOmjYAs3BX8tOsbMPnovvLplgzFND4=; b=cK/CT4+cjNdaqB/bq6onYRvRuaBZiEQDxJZG3nZzbEWSoC22iV0dPOwDBcGV9HX56D ND6Dj+1FAVJ3cyJqxC6tzp37/UegCdsU6f3uc8/xmd7dASF2LgPnKUagTPDKHP/8NHNt 3BARM+d3uKUnKHohwayXHbVwzBTXlm1BpUQrQt3KRLGma2vsLHEwWwMc85X7sJMUZ7T1 V94yzxg+1k1xKAlHHYEtYsLFkXDyZTJIaESXgLOgP0zOsJPOttKrGFC1hJafHCDD+vB1 TbO/XqsMj+UevbYicLmvXG93/GnrSdajRVKMNZ2RI/vhaedDbO3UM1TeVmiVun/eh8fs RnUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZafyWrCRm6FANBOmjYAs3BX8tOsbMPnovvLplgzFND4=; b=XzA/TNUSBhY/dXACz6BmMPOsgQ4sZji33afuyfcNDGa6t8wUl0y0db5smVsVBsnDnU jv6ju9OxWsJiLUA+fD3h2J/0EKp/ANgsnUyW13spNczdnrzbu/GPMnUGxPIX91tCwqlu 5uWajSyNzhebUIjcJ2eSI7ASS9iyx2cBgBxnZKnHRQA0bk0+NiaCLaeqoAOH1Fux5o+b rmWSuvqXQO+ucUZuJGmVaZ5QLLINsch6thquqkuZuGbm6GQDERiDecXECX/CIoGk9qIi N6tXjWCOLxjLe+LZNs5KiqwZum9tvktor/bS6eqiq8jObG0G1B6ZgsYPTC+49vXXGAxk TxbQ== X-Gm-Message-State: AOAM5304zg+hAbfvhn5gpTPEHX/BKghUwwBV/IxsrgVYzd+PbDxTGUFa R7k6X6llnb2Orc34imQc8jeqRY+LZV0t+RxfRseM6g== X-Google-Smtp-Source: ABdhPJwu8VhHKIziIJ82Xtt68TP37xWYiasNx7hKoh62sy8WoW2FuyExQ5/AfbTQOYpOaJf6aCN7/8GJjrix3c7mR9Q= X-Received: by 2002:a81:6a0a:0:b0:2d0:c144:4be4 with SMTP id f10-20020a816a0a000000b002d0c1444be4mr28608461ywc.332.1646184185795; Tue, 01 Mar 2022 17:23:05 -0800 (PST) MIME-Version: 1.0 References: <1646133431-8948-1-git-send-email-lena.wang@mediatek.com> In-Reply-To: <1646133431-8948-1-git-send-email-lena.wang@mediatek.com> From: Eric Dumazet Date: Tue, 1 Mar 2022 17:22:54 -0800 Message-ID: Subject: Re: [PATCH net v2] net: fix up skbs delta_truesize in UDP GRO frag_list To: lena wang Cc: Paolo Abeni , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Willem de Bruijn , Daniel Borkmann , Dongseok Yi , wsd_upstream@mediatek.com, netdev , LKML , Linux ARM , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 1, 2022 at 3:23 AM lena wang wrote: > > The truesize for a UDP GRO packet is added by main skb and skbs in main > skb's frag_list: > skb_gro_receive_list > p->truesize += skb->truesize; > > > > Fixes: 53475c5dd856 ("net: fix use-after-free when UDP GRO with shared fraglist") > Signed-off-by: lena wang > Acked-by: Paolo Abeni > --- > change since v1: > 1) add the fix tag. > 2) add net subtree to the subject > --- > --- > net/core/skbuff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Eric Dumazet