From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBB9CC433E6 for ; Wed, 10 Mar 2021 09:33:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C4D764FF1 for ; Wed, 10 Mar 2021 09:33:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbhCJJcr (ORCPT ); Wed, 10 Mar 2021 04:32:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48132 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231489AbhCJJcQ (ORCPT ); Wed, 10 Mar 2021 04:32:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615368735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a/DGLUjr6IILhrnvlay+wj8znvny6CeX2t2rrG8Z35w=; b=ciB9T3xq7P1SFhCuUiVy1do1gcAGm0YIDC38N7Z3jaKajpyyt91ZJxIqfO34q8RYrqhr8Z BGsTsi+vH7EA2U7kiIRsIxpq7Av77NFaFUXrMBBSD93l2iXBBXCcIyvG+q3e4blabI5Aou 1SX4JPNXh64WyUpD4PMXdwCuxWtC61k= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-TmGl4S8vMUG9EUTuCIPr2Q-1; Wed, 10 Mar 2021 04:32:13 -0500 X-MC-Unique: TmGl4S8vMUG9EUTuCIPr2Q-1 Received: by mail-wr1-f69.google.com with SMTP id 75so7661230wrl.3 for ; Wed, 10 Mar 2021 01:32:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a/DGLUjr6IILhrnvlay+wj8znvny6CeX2t2rrG8Z35w=; b=TNBOBMawpjryaeWSWnWaJNN6vFfsmfx9ld95zj4xHSZ7mQO4Ft/bqIRh3UnRxkYesa 4kuAPVIVLlIGT8xW+VdFO6GJFvUIwS1tFTavvl1e2JfhR9OTaNgbJoep4LOBNXnc/tFb SMdaAC4rRdeJyRREZmpsPCgypLonYxEijMBGJXsQZD3SwKI1KTqj4lZ0JmuAyigKwIMK azsf0QiFdVB78OBQMQqyAx+aIrVWLcJ4STPiRx0BzZcC6Tvbasjae3SnsgVBy+SjM7+X 1ow+kv0R3HIM0LFGH0tgY2+0u3I1zymqWR8G2brtRV9CUe6XwpCGr099eYZJ7c0pwY2n tB9g== X-Gm-Message-State: AOAM530fhrapJo3rBX7QT3zHQpLNwtOr6IpqpOt/+IIVwyEq1DHu0ROy DCjT0fJxLFVBZ0rmsX4jVxniJIb+Gqx+ZgRXbcH2H+zgDmlSr3BdjGjeHnkIkDLNZgtL34yInGU RzRZ8krsObxk7SbHkHQGsL0jlJfko7sBXoU77rtfx X-Received: by 2002:a1c:9a92:: with SMTP id c140mr2302131wme.167.1615368732287; Wed, 10 Mar 2021 01:32:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJz6CFSwlUzoJ4DXYOWb33EVxww5GlWKF+Jye6YtiyemSL6//yJ3H6N2hZHNqqPE7V+05jeDqd5YlGft8h3cH0w= X-Received: by 2002:a1c:9a92:: with SMTP id c140mr2302102wme.167.1615368732055; Wed, 10 Mar 2021 01:32:12 -0800 (PST) MIME-Version: 1.0 References: <1615357366-97612-1-git-send-email-jiapeng.chong@linux.alibaba.com> In-Reply-To: <1615357366-97612-1-git-send-email-jiapeng.chong@linux.alibaba.com> From: Yauheni Kaliuta Date: Wed, 10 Mar 2021 11:31:56 +0200 Message-ID: Subject: Re: [PATCH] selftests/bpf: fix warning comparing pointer to 0 To: Jiapeng Chong Cc: shuah , Alexei Starovoitov , Daniel Borkmann , andrii@kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , john.fastabend@gmail.com, kpsingh@kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , netdev@vger.kernel.org, bpf , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 8:23 AM Jiapeng Chong wrote: > > Fix the following coccicheck warning: > > ./tools/testing/selftests/bpf/progs/test_global_func10.c:17:12-13: > WARNING comparing pointer to 0. but it's ok from the C standard point of view > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > tools/testing/selftests/bpf/progs/test_global_func10.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/progs/test_global_func10.c b/tools/testing/selftests/bpf/progs/test_global_func10.c > index 61c2ae9..97b7031 100644 > --- a/tools/testing/selftests/bpf/progs/test_global_func10.c > +++ b/tools/testing/selftests/bpf/progs/test_global_func10.c > @@ -14,7 +14,7 @@ struct Big { > > __noinline int foo(const struct Big *big) > { > - if (big == 0) > + if (!big) > return 0; > > return bpf_get_prandom_u32() < big->y; > -- > 1.8.3.1 > -- WBR, Yauheni