From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A24C4332F for ; Fri, 3 Dec 2021 23:42:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383560AbhLCXpm (ORCPT ); Fri, 3 Dec 2021 18:45:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383562AbhLCXpj (ORCPT ); Fri, 3 Dec 2021 18:45:39 -0500 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10C16C061359 for ; Fri, 3 Dec 2021 15:42:15 -0800 (PST) Received: by mail-ot1-x335.google.com with SMTP id r10-20020a056830080a00b0055c8fd2cebdso5381969ots.6 for ; Fri, 03 Dec 2021 15:42:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4JwQlDJ0eW7f9hYvr2thOhENg/qO/ZaZzGs6+sDFshM=; b=AJ/TTnwyVYSX6l2dbIpeBUSjXxXc1p865vm+D2RhGu04FOd1dojH/S075xAjkHvREE CX63gNQpg8eFmDqxN/+1Qwah0kEZdrJU5IZLuEmukgMBSbGT8ZVsX87ACdVvxTvnXDBK mZYWElg8rD4PTchWPB7nykjdZkyxRmpHBGGNR8kqpq8vCZXDfxbqez7uIQ5NdV7hMoCV Lf3SWZgqQW1MzTH/UOTBSje7705REt9thTaNdYmeUjFBEC9AlYqm2gHhrWgfoy3hsGkp iLaT99dRzBy0QEyguUM6y79ZuC6inrGFlSDfBARE+En7rgXRrfkwyxOXfrRn2Ukcdd0x ZlTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4JwQlDJ0eW7f9hYvr2thOhENg/qO/ZaZzGs6+sDFshM=; b=L6mbwSeHE3h65aPJiBYmzEPqiLTJljz6mwZo/4vt9UFZhHEmjdIGeUzKt5GF/CgOzq bnn0bDeHwPAd5EmmlGqAszYy4Nd3KJASMQRo78xG/2RsGWTNn9S962xLGxE0Vt9tmXcS ZMEMa/jw7zGFyqI1z6H4ulLX1cgWNryeHat/4pzi9zBHxT0HKlp3OgAZJDtacChuob+N ppkgvCETmVk0bS9KYzFZNEjp45ujrTQnaJjluQ/qLR8M6e5y0q+E3NARbdDaWJwwXuwU sOtZpHDnd7IRqpqDtAqvpCK2I+CdP/0lWoZx/wKr30OcMx1yBYnsLSXMVIRuqh6WK0PM XoPw== X-Gm-Message-State: AOAM532SOmOiVzyKN0Ymdu4SMHyxVaKC1EcjU3eZjeWIDqeXEMaWydfg jgfavi+ZuGuvomd2eyY25tYyKj/Zx2YIFW4NPUptFw== X-Google-Smtp-Source: ABdhPJzmeHxYPCJX3eYijPp8C1oQT6JTRLMS+qeYs0OAMS77tBDynJpAjMPOmqpeKVSmDxkzBYLKtTfkIQWBc6uaOn0= X-Received: by 2002:a9d:7548:: with SMTP id b8mr18387018otl.92.1638574934196; Fri, 03 Dec 2021 15:42:14 -0800 (PST) MIME-Version: 1.0 References: <20211130114433.2580590-1-elver@google.com> <20211130114433.2580590-5-elver@google.com> <20211203165020.GR641268@paulmck-ThinkPad-P17-Gen-1> <20211203210856.GA712591@paulmck-ThinkPad-P17-Gen-1> In-Reply-To: <20211203210856.GA712591@paulmck-ThinkPad-P17-Gen-1> From: Marco Elver Date: Sat, 4 Dec 2021 00:42:02 +0100 Message-ID: Subject: Re: [PATCH v3 04/25] kcsan: Add core support for a subset of weak memory modeling To: paulmck@kernel.org Cc: Alexander Potapenko , Boqun Feng , Borislav Petkov , Dmitry Vyukov , Ingo Molnar , Mark Rutland , Peter Zijlstra , Thomas Gleixner , Waiman Long , Will Deacon , kasan-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 Dec 2021 at 22:09, Paul E. McKenney wrote: [...] > A few quick tests located the following: > > [ 0.635383] INFO: trying to register non-static key. > [ 0.635804] The code is fine but needs lockdep annotation, or maybe > [ 0.636194] you didn't initialize this object before use? > [ 0.636194] turning off the locking correctness validator. > [ 0.636194] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.16.0-rc1+ #3208 [...] > When running without the new patch series, this splat does not appear. > > Do I need a toolchain upgrade? I see the Clang 14.0 in the cover letter, > but that seems to apply only to non-x86 architectures. > > $ clang-11 -v > Ubuntu clang version 11.1.0-++20210805102428+1fdec59bffc1-1~exp1~20210805203044.169 Good catch! That would be lockdep telling me off for putting test locks on the stack. :-/ I thought I had tested this with lockdep, but it seems the set of semi-automated tests I run didn't (yet) generate a config with KCSAN_WEAK_MEMORY + LOCKDEP. This should be fixed by: https://lkml.kernel.org/r/20211203233817.2815340-1-elver@google.com Thanks, -- Marco